Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Unified Diff: Source/core/dom/Node.h

Issue 1265573003: Fix crash on null ptr dereference in EventPath propagation (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: update the comment (not necessarily async events) Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Node.h
diff --git a/Source/core/dom/Node.h b/Source/core/dom/Node.h
index 0b7532bea9cf156e1539fb5dc399c6b6cf4a6b05..987850210a64146ebf12895c5dba9392f61f1cc1 100644
--- a/Source/core/dom/Node.h
+++ b/Source/core/dom/Node.h
@@ -295,6 +295,9 @@ public:
bool hasCustomStyleCallbacks() const { return getFlag(HasCustomStyleCallbacksFlag); }
// If this node is in a shadow tree, returns its shadow host. Otherwise, returns nullptr.
+ // TODO(kochi): crbug.com/507413 shadowHost() can return nullptr even when it is in a
+ // shadow tree but its root is detached from its host. This can happen when handling
+ // queued events (e.g. during execCommand()).
Element* shadowHost() const;
ShadowRoot* containingShadowRoot() const;
ShadowRoot* youngestShadowRoot() const;
« no previous file with comments | « LayoutTests/fast/events/event-fire-disconnected-shadow-dom-crash-expected.txt ('k') | Source/core/dom/shadow/ShadowRoot.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698