Issue 1265123002: Make DeleteSelectionCommand not to use Position::deprecatedEditingOffset()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1265123002: Make DeleteSelectionCommand not to use Position::deprecatedEditingOffset() (Closed)

Created:
5 years, 4 months ago by yosin_UTC9

Modified:
5 years, 4 months ago

Reviewers:
tkent, yoichio, hajimehoshi

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Make DeleteSelectionCommand not to use Position::deprecatedEditingOffset() This patch replaces |Position::deprecatedEditingOffset()| call in |DeleteSelectionCommand| class by |Position::computeEditingOffset()|, since it is used for computing offset for upstream/downstream positions which can not be middle of editing ignore content, for improving code health. This patch is a preparation of getting rid of legacy editing position. BUG=513114 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199886

Patch Set 1 : 2015-08-03T15:48:20 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	Source/core/editing/DeleteSelectionCommand.cpp	View		6 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265123002/1

5 years, 4 months ago (2015-08-03 08:30:01 UTC) #5

commit-bot: I haz the power

5 years, 4 months ago (2015-08-03 08:33:35 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199886

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages