src/IceCfg.cpp - Issue 1265023003: Clarify which type "Label" refers to (generic vs X86)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceCfg.cpp

Issue 1265023003: Clarify which type "Label" refers to (generic vs X86) (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: not LabelBase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceCfg.cpp

diff --git a/src/IceCfg.cpp b/src/IceCfg.cpp

index c19d01a464020bc5ce4c9d5750f7907531a82293..847563cc809654d7e1435d6d7e925d08ce264c92 100644

--- a/src/IceCfg.cpp

+++ b/src/IceCfg.cpp

@@ -664,8 +664,7 @@ void Cfg::emitJumpTables() {

Ctx->addJumpTable(MangledName, JumpTable->getId(), NumTargets);

for (SizeT I = 0; I < NumTargets; ++I) {

SizeT Index = JumpTable->getTarget(I)->getIndex();

- JT.pushTarget(

- getAssembler()->getOrCreateCfgNodeLabel(Index)->getPosition());

+ JT.pushTarget(getAssembler()->getCfgNodeLabel(Index)->getPosition());

}

} break;

« src/IceAssemblerX8632.h ('K') | « src/IceAssemblerX86BaseImpl.h ('k') | no next file » | no next file with comments »