src/IceAssemblerX8632.h - Issue 1265023003: Clarify which type "Label" refers to (generic vs X86)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceAssemblerX8632.h

Issue 1265023003: Clarify which type "Label" refers to (generic vs X86) (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: not LabelBase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceAssemblerX8632.h

diff --git a/src/IceAssemblerX8632.h b/src/IceAssemblerX8632.h

index 13f5606999ce7075d80a8dc7db193b99cf332716..fb9eedf9a81e0d5255d508cb5f7fead37c4dc0a6 100644

--- a/src/IceAssemblerX8632.h

+++ b/src/IceAssemblerX8632.h

@@ -38,6 +38,7 @@ class TargetX8632;

namespace X8632 {

using Immediate = ::Ice::X86Internal::Immediate;

+using Label = ::Ice::X86Internal::Label;

jvoung (off chromium) 2015/08/03 17:19:21 I think this was actually the only line needed to

class AssemblerX8632 : public X86Internal::AssemblerX86Base<TargetX8632> {

AssemblerX8632(const AssemblerX8632 &) = delete;

« no previous file with comments | « src/IceAssemblerMIPS32.h ('k') | src/IceAssemblerX86Base.h » ('j') | no next file with comments »