Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1264913003: Buildbucket: tryjob ACL (Closed)

Created:
5 years, 4 months ago by nodir
Modified:
5 years, 4 months ago
Reviewers:
smut, Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8@config
Target Ref:
refs/pending/heads/infra/config
Project:
v8
Visibility:
Public.

Description

Buildbucket: tryjob ACL Allowed tryjob access to project-v8-tryjob-access Also added codereview.settings file. R=smut@google.com, machenbach@chromium.org, smut@googlel.com BUG=461614 Committed: https://chromium.googlesource.com/v8/v8/+/bd32e7f146122fc80daf1295c215be451fb10199

Patch Set 1 #

Patch Set 2 : owners #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
A OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
A codereview.settings View 1 chunk +4 lines, -0 lines 0 comments Download
M cr-buildbucket.cfg View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
nodir
PTAL
5 years, 4 months ago (2015-07-30 20:22:57 UTC) #2
smut
lgtm
5 years, 4 months ago (2015-07-30 20:28:46 UTC) #3
nodir
Committed patchset #2 (id:20001) manually as bd32e7f146122fc80daf1295c215be451fb10199 (presubmit successful).
5 years, 4 months ago (2015-07-30 20:31:59 UTC) #4
Michael Achenbach
5 years, 4 months ago (2015-07-31 08:16:19 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698