Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1264813002: [Android] Fix crashes on Chrome internal pages. (Closed)

Created:
5 years, 4 months ago by Kibeom Kim (inactive)
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix crashes on Chrome internal pages. CompositorViewHolder#mControlContainer can be null on viewing internal pages, so check it before using it. Also fixed progress bar API calling order in LoadProgressSimulator. BUG=514955 Committed: https://crrev.com/1bde929fcf8b4ec353b3b9818256910f6dcad426 Cr-Commit-Position: refs/heads/master@{#341198}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : mProgressBarDrawingInfo = null; #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264813002/1
5 years, 4 months ago (2015-07-30 06:06:16 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264813002/20001
5 years, 4 months ago (2015-07-30 06:09:19 UTC) #4
Kibeom Kim (inactive)
5 years, 4 months ago (2015-07-30 06:10:39 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-30 07:17:57 UTC) #8
Ted C
https://codereview.chromium.org/1264813002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java File chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java (right): https://codereview.chromium.org/1264813002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java#newcode548 chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java:548: mProgressBarDrawingInfo = null; why do you need to set ...
5 years, 4 months ago (2015-07-30 15:02:13 UTC) #9
Kibeom Kim (inactive)
https://codereview.chromium.org/1264813002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java File chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java (right): https://codereview.chromium.org/1264813002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java#newcode548 chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java:548: mProgressBarDrawingInfo = null; On 2015/07/30 15:02:13, Ted C wrote: ...
5 years, 4 months ago (2015-07-30 17:00:28 UTC) #10
David Trainor- moved to gerrit
lgtm
5 years, 4 months ago (2015-07-30 20:54:34 UTC) #11
Kibeom Kim (inactive)
Ted: I'll land as it is for now as this is a Dev blocker, but ...
5 years, 4 months ago (2015-07-30 20:55:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264813002/40001
5 years, 4 months ago (2015-07-30 20:57:35 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-07-30 21:37:39 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 21:38:21 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1bde929fcf8b4ec353b3b9818256910f6dcad426
Cr-Commit-Position: refs/heads/master@{#341198}

Powered by Google App Engine
This is Rietveld 408576698