Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2592)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

Issue 1264813002: [Android] Fix crashes on Chrome internal pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mProgressBarDrawingInfo = null; Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
index 2c744fc86b10d88575ee17756b361e61a1133d72..d5e9c01a7e7ab90766bbc60f2bf71c6995e7851b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
@@ -223,7 +223,6 @@ public class CompositorViewHolder extends FrameLayout
}
});
- if (!DeviceFormFactor.isTablet(getContext())) mProgressBarDrawingInfo = new DrawingInfo();
mCompositorView = new CompositorView(getContext(), this);
addView(mCompositorView,
new FrameLayout.LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.WRAP_CONTENT));
@@ -541,9 +540,14 @@ public class CompositorViewHolder extends FrameLayout
TraceEvent.begin("CompositorViewHolder:layout");
if (mLayoutManager != null) {
mLayoutManager.onUpdate();
- if (mProgressBarDrawingInfo != null) {
+
+ if (!DeviceFormFactor.isTablet(getContext()) && mControlContainer != null) {
+ if (mProgressBarDrawingInfo == null) mProgressBarDrawingInfo = new DrawingInfo();
mControlContainer.getProgressBarDrawingInfo(mProgressBarDrawingInfo);
+ } else {
+ assert mProgressBarDrawingInfo == null;
}
+
mCompositorView.finalizeLayers(mLayoutManager, mSkipNextToolbarTextureUpdate,
mProgressBarDrawingInfo);
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698