Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3577)

Unified Diff: chrome/renderer/resources/extensions/storage_custom_bindings.js

Issue 12647017: Lazily require types when validating Extensions API calls (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixes Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/storage_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/storage_custom_bindings.js b/chrome/renderer/resources/extensions/storage_custom_bindings.js
deleted file mode 100644
index 5d40e1d9bfba203fbd4551e13eabc97752693e8f..0000000000000000000000000000000000000000
--- a/chrome/renderer/resources/extensions/storage_custom_bindings.js
+++ /dev/null
@@ -1,49 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-// Custom binding for the storage API.
-
-var binding = require('binding').Binding.create('storage');
-
-var forEach = require('utils').forEach;
-var normalizeArgumentsAndValidate =
- require('schemaUtils').normalizeArgumentsAndValidate
-var sendRequest = require('sendRequest').sendRequest;
-
-binding.registerCustomType('storage.StorageArea', function() {
- function extendSchema(schema) {
- var extendedSchema = schema.slice();
- extendedSchema.unshift({'type': 'string'});
- return extendedSchema;
- }
-
- function StorageArea(namespace, schema) {
- // Binds an API function for a namespace to its browser-side call, e.g.
- // storage.sync.get('foo') -> (binds to) ->
- // storage.get('sync', 'foo').
- //
- // TODO(kalman): Put as a method on CustombindingObject and re-use (or
- // even generate) for other APIs that need to do this. Same for other
- // callers of registerCustomType().
- var self = this;
- function bindApiFunction(i, functionName) {
- self[functionName] = function() {
- var funSchema = this.functionSchemas[functionName];
- var args = Array.prototype.slice.call(arguments);
- args = normalizeArgumentsAndValidate(args, funSchema);
- return sendRequest(
- 'storage.' + functionName,
- [namespace].concat(args),
- extendSchema(funSchema.definition.parameters),
- {preserveNullInObjects: true});
- };
- }
- var apiFunctions = ['get', 'set', 'remove', 'clear', 'getBytesInUse'];
- forEach(apiFunctions, bindApiFunction);
- }
-
- return StorageArea;
-});
-
-exports.binding = binding.generate();

Powered by Google App Engine
This is Rietveld 408576698