Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4590)

Unified Diff: chrome/renderer/resources/extensions/types_custom_bindings.js

Issue 12647017: Lazily require types when validating Extensions API calls (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixes Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/types_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/types_custom_bindings.js b/chrome/renderer/resources/extensions/types_custom_bindings.js
deleted file mode 100644
index 1c386f4fd69729bcc40ad23c0d8ed7ad09679f39..0000000000000000000000000000000000000000
--- a/chrome/renderer/resources/extensions/types_custom_bindings.js
+++ /dev/null
@@ -1,51 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-// Custom binding for the types API.
-
-var binding = require('binding').Binding.create('types');
-
-var chrome = requireNative('chrome').GetChrome();
-var sendRequest = require('sendRequest').sendRequest;
-var validate = require('schemaUtils').validate;
-
-binding.registerCustomType('types.ChromeSetting', function() {
-
- function extendSchema(schema) {
- var extendedSchema = schema.slice();
- extendedSchema.unshift({'type': 'string'});
- return extendedSchema;
- }
-
- function ChromeSetting(prefKey, valueSchema) {
- this.get = function(details, callback) {
- var getSchema = this.functionSchemas.get.definition.parameters;
- validate([details, callback], getSchema);
- return sendRequest('types.ChromeSetting.get',
- [prefKey, details, callback],
- extendSchema(getSchema));
- };
- this.set = function(details, callback) {
- var setSchema = this.functionSchemas.set.definition.parameters.slice();
- setSchema[0].properties.value = valueSchema;
- validate([details, callback], setSchema);
- return sendRequest('types.ChromeSetting.set',
- [prefKey, details, callback],
- extendSchema(setSchema));
- };
- this.clear = function(details, callback) {
- var clearSchema = this.functionSchemas.clear.definition.parameters;
- validate([details, callback], clearSchema);
- return sendRequest('types.ChromeSetting.clear',
- [prefKey, details, callback],
- extendSchema(clearSchema));
- };
- this.onChange = new chrome.Event('types.ChromeSetting.' + prefKey +
- '.onChange');
- };
-
- return ChromeSetting;
-});
-
-exports.binding = binding.generate();

Powered by Google App Engine
This is Rietveld 408576698