Issue 1264573004: Need to check for positional rules on parent with style change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1264573004: Need to check for positional rules on parent with style change. (Closed)

Created:
5 years, 4 months ago by rune

Modified:
5 years, 4 months ago

Reviewers:
dstockwell, Timothy Loh

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Need to check for positional rules on parent with style change. A local style change on the parent inhibited checks for positional rule changes on children with an early return. Removed that early return. R=dstockwell@chromium.org BUG=510732 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199950

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -3 lines)			Patch
A	LayoutTests/fast/css/nth-child-dynamic-002.html	View	1 chunk	+21 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/css/nth-child-dynamic-002-expected.txt	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	Source/core/dom/ContainerNode.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264573004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264573004/1

5 years, 4 months ago (2015-08-04 06:50:50 UTC) #5

commit-bot: I haz the power

5 years, 4 months ago (2015-08-04 06:54:27 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199950

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages