Re-connect search on MD downloads

Re-connect search on MD downloads

Also fix "Clear all" for a Polymer world.

Prev CL: https://codereview.chromium.org/1259363004/

R=michaelpg@chromium.org
BUG=425626
Committed: https://crrev.com/cb9bc921c0bdad536a7272f67a08084062573735
Cr-Commit-Position: refs/heads/master@{#341181}

[Dan Beam, 2015-07-29 04:40:09]

https://codereview.chromium.org/1264553002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/v1_0/cr_input/cr_input.js (right):

https://codereview.chromium.org/1264553002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/cr_input/cr_input.js:89:
this.$.input.inputElement.focus();
don't we have tests that are supposed to find this stuff?

[Dan Beam, 2015-07-29 04:43:41]

https://codereview.chromium.org/1264553002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_downloads/toolbar.js (right):

https://codereview.chromium.org/1264553002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/toolbar.js:30: return
!this.$['search-term'].shadowRoot.activeElement;
til: http://www.w3.org/TR/shadow-dom/#active-element

[Dan Beam, 2015-07-29 17:35:00]

Patchset #2 (id:20001) has been deleted

[michaelpg, 2015-07-30 02:48:16]

lgtm w/ optional suggestion

https://codereview.chromium.org/1264553002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_downloads/toolbar.html (right):

https://codereview.chromium.org/1264553002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/toolbar.html:16:
on-click="onClearAllClick_"></cr-button>
suggestion: hidden="[[!canClearAll(searchTerm, downloadsShowing)]]"

https://codereview.chromium.org/1264553002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/toolbar.html:24:
hidden$="[[!showingSearch_]]" no-label-float></cr-input>
with the above suggestion: value="{{searchTerm}}"

https://codereview.chromium.org/1264553002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_downloads/toolbar.js (right):

https://codereview.chromium.org/1264553002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/toolbar.js:52: this.updateClearAll_();
Consider using Polymer features instead of calling one-off update functions like
this. See above.

https://codereview.chromium.org/1264553002/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/v1_0/cr_input/cr_input.js (right):

https://codereview.chromium.org/1264553002/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/v1_0/cr_input/cr_input.js:89:
this.$.input.inputElement.focus();
On 2015/07/29 04:40:09, Dan Beam wrote:
> don't we have tests that are supposed to find this stuff?

not yet! We have tests for 1 element: src/chrome/test/data/webui/cr_elements/

It shouldn't be painful to add more though. It's on my to-do list and we can
shard out the tests if we wanna prioritize them.

[Dan Beam, 2015-07-30 18:54:23]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2015-07-30 18:55:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1264553002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1264553002/1

[commit-bot: I haz the power, 2015-07-30 20:15:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-07-30 20:15:56]

Patchset 1 (id:??) landed as
https://crrev.com/cb9bc921c0bdad536a7272f67a08084062573735
Cr-Commit-Position: refs/heads/master@{#341181}