Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1264553002: Re-connect search on MD downloads (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@dl-misc6
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-connect search on MD downloads Also fix "Clear all" for a Polymer world. Prev CL: https://codereview.chromium.org/1259363004/ R=michaelpg@chromium.org BUG=425626 Committed: https://crrev.com/cb9bc921c0bdad536a7272f67a08084062573735 Cr-Commit-Position: refs/heads/master@{#341181}

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -7 lines) Patch
M chrome/browser/resources/md_downloads/manager.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.html View 2 chunks +2 lines, -2 lines 2 comments Download
M chrome/browser/resources/md_downloads/toolbar.js View 3 chunks +45 lines, -2 lines 2 comments Download
M ui/webui/resources/cr_elements/v1_0/cr_input/cr_input.js View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 8 (2 generated)
Dan Beam
https://codereview.chromium.org/1264553002/diff/1/ui/webui/resources/cr_elements/v1_0/cr_input/cr_input.js File ui/webui/resources/cr_elements/v1_0/cr_input/cr_input.js (right): https://codereview.chromium.org/1264553002/diff/1/ui/webui/resources/cr_elements/v1_0/cr_input/cr_input.js#newcode89 ui/webui/resources/cr_elements/v1_0/cr_input/cr_input.js:89: this.$.input.inputElement.focus(); don't we have tests that are supposed to ...
5 years, 4 months ago (2015-07-29 04:40:09 UTC) #1
Dan Beam
https://codereview.chromium.org/1264553002/diff/1/chrome/browser/resources/md_downloads/toolbar.js File chrome/browser/resources/md_downloads/toolbar.js (right): https://codereview.chromium.org/1264553002/diff/1/chrome/browser/resources/md_downloads/toolbar.js#newcode30 chrome/browser/resources/md_downloads/toolbar.js:30: return !this.$['search-term'].shadowRoot.activeElement; til: http://www.w3.org/TR/shadow-dom/#active-element
5 years, 4 months ago (2015-07-29 04:43:41 UTC) #2
michaelpg
lgtm w/ optional suggestion https://codereview.chromium.org/1264553002/diff/1/chrome/browser/resources/md_downloads/toolbar.html File chrome/browser/resources/md_downloads/toolbar.html (right): https://codereview.chromium.org/1264553002/diff/1/chrome/browser/resources/md_downloads/toolbar.html#newcode16 chrome/browser/resources/md_downloads/toolbar.html:16: on-click="onClearAllClick_"></cr-button> suggestion: hidden="[[!canClearAll(searchTerm, downloadsShowing)]]" https://codereview.chromium.org/1264553002/diff/1/chrome/browser/resources/md_downloads/toolbar.html#newcode24 ...
5 years, 4 months ago (2015-07-30 02:48:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264553002/1
5 years, 4 months ago (2015-07-30 18:55:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-30 20:15:30 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 20:15:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb9bc921c0bdad536a7272f67a08084062573735
Cr-Commit-Position: refs/heads/master@{#341181}

Powered by Google App Engine
This is Rietveld 408576698