 Chromium Code Reviews
 Chromium Code Reviews Issue 1264553002:
  Re-connect search on MD downloads  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@dl-misc6
    
  
    Issue 1264553002:
  Re-connect search on MD downloads  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@dl-misc6| OLD | NEW | 
|---|---|
| 1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html"> | 1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html"> | 
| 2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.h tml"> | 2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.h tml"> | 
| 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> | 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> | 
| 4 <link rel="import" href="chrome://resources/cr_elements/v1_0/cr_button/cr_button .html"> | 4 <link rel="import" href="chrome://resources/cr_elements/v1_0/cr_button/cr_button .html"> | 
| 5 <link rel="import" href="chrome://resources/cr_elements/v1_0/cr_input/cr_input.h tml"> | 5 <link rel="import" href="chrome://resources/cr_elements/v1_0/cr_input/cr_input.h tml"> | 
| 6 <link rel="import" href="chrome://resources/html/assert.html"> | |
| 6 <link rel="import" href="chrome://resources/html/cr.html"> | 7 <link rel="import" href="chrome://resources/html/cr.html"> | 
| 7 | 8 | 
| 8 <dom-module id="downloads-toolbar"> | 9 <dom-module id="downloads-toolbar"> | 
| 9 <template> | 10 <template> | 
| 10 <div id="title"> | 11 <div id="title"> | 
| 11 <h1 i18n-content="title"></h1> | 12 <h1 i18n-content="title"></h1> | 
| 12 </div> | 13 </div> | 
| 13 <div id="actions"> | 14 <div id="actions"> | 
| 14 <cr-button id="clear-all" i18n-content="clearAll" | 15 <cr-button id="clear-all" i18n-content="clearAll" | 
| 15 on-click="onClearAllClick_" | 16 on-click="onClearAllClick_"></cr-button> | 
| 
michaelpg
2015/07/30 02:48:16
suggestion: hidden="[[!canClearAll(searchTerm, dow
 | |
| 16 hidden$="[[!canClearAll]]"></cr-button> | |
| 17 <cr-button id="open-downloads-folder" i18n-content="openDownloadsFolder" | 17 <cr-button id="open-downloads-folder" i18n-content="openDownloadsFolder" | 
| 18 on-click="onOpenDownloadsFolderClick_"></cr-button> | 18 on-click="onOpenDownloadsFolderClick_"></cr-button> | 
| 19 </div> | 19 </div> | 
| 20 <div id="search"> | 20 <div id="search"> | 
| 21 <paper-icon-button icon="search" id="search-button" | 21 <paper-icon-button icon="search" id="search-button" | 
| 22 on-click="toggleShowingSearch_"></paper-icon-button> | 22 on-click="toggleShowingSearch_"></paper-icon-button> | 
| 23 <cr-input id="search-term" i18n-values="label:search" | 23 <cr-input id="search-term" i18n-values="label:search" | 
| 24 hidden$="[[!showingSearch_]]" no-label-float></cr-input> | 24 hidden$="[[!showingSearch_]]" no-label-float></cr-input> | 
| 
michaelpg
2015/07/30 02:48:16
with the above suggestion: value="{{searchTerm}}"
 | |
| 25 <paper-icon-button icon="clear" id="clear-search" | 25 <paper-icon-button icon="clear" id="clear-search" | 
| 26 on-click="toggleShowingSearch_" | 26 on-click="toggleShowingSearch_" | 
| 27 hidden$="[[!showingSearch_]]"></paper-icon-button> | 27 hidden$="[[!showingSearch_]]"></paper-icon-button> | 
| 28 </div> | 28 </div> | 
| 29 </template> | 29 </template> | 
| 30 <link rel="import" type="css" href="chrome://downloads/shared_style.css"> | 30 <link rel="import" type="css" href="chrome://downloads/shared_style.css"> | 
| 31 <link rel="import" type="css" href="chrome://downloads/toolbar.css"> | 31 <link rel="import" type="css" href="chrome://downloads/toolbar.css"> | 
| 32 <script src="chrome://downloads/toolbar.js"></script> | 32 <script src="chrome://downloads/toolbar.js"></script> | 
| 33 </dom-module> | 33 </dom-module> | 
| OLD | NEW |