Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 1264543003: Revert of ipc: Clean up interface of attachment broker. (Closed)

Created:
5 years, 4 months ago by erikchen
Modified:
5 years, 4 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ipc: Clean up interface of attachment broker. (patchset #5 id:80001 of https://codereview.chromium.org/1269553003/) Reason for revert: Causes errors on win7. http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/40371 Original issue's description: > ipc: Clean up interface of attachment broker. > > AttachmentBrokerUnprivileged now has a method > DesignateBrokerCommunicationChannel which is used by non-broker processes to > designate an IPC::Channel as the communication medium for brokerable attachment > messages. IPC::Channel has a new member attachment_broker_endpoint_ which causes > it to pass all messages through the attachment broker before forwarding them to > the listener. > > BUG=493414 > > Committed: https://crrev.com/9a06836982214f2edced21bbd1615b49e7f231bf > Cr-Commit-Position: refs/heads/master@{#341143} TBR=tsepez@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=493414

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -62 lines) Patch
M ipc/attachment_broker_privileged.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/attachment_broker_privileged_win_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M ipc/attachment_broker_unprivileged.h View 2 chunks +1 line, -4 lines 0 comments Download
M ipc/attachment_broker_unprivileged.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M ipc/ipc_channel.h View 2 chunks +0 lines, -12 lines 0 comments Download
M ipc/ipc_channel_nacl.h View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_channel_nacl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ipc/ipc_channel_posix.h View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_channel_posix.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ipc/ipc_channel_reader.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ipc/ipc_channel_reader.cc View 1 chunk +2 lines, -11 lines 0 comments Download
M ipc/ipc_channel_reader_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ipc/ipc_channel_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_channel_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
erikchen
Created Revert of ipc: Clean up interface of attachment broker.
5 years, 4 months ago (2015-07-30 20:48:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264543003/1
5 years, 4 months ago (2015-07-30 20:49:14 UTC) #2
commit-bot: I haz the power
Failed to apply the patch.
5 years, 4 months ago (2015-07-30 20:50:53 UTC) #4
erikchen
5 years, 4 months ago (2015-07-30 20:52:01 UTC) #5
On 2015/07/30 20:50:53, commit-bot: I haz the power wrote:
> Failed to apply the patch.

Already reverted.

Powered by Google App Engine
This is Rietveld 408576698