Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 126453004: Base: Rename File::error() to File::error_details() (Closed)

Created:
6 years, 11 months ago by rvargas (doing something else)
Modified:
6 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Base: Rename File::error() to File::error_details() BUG=322664 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243676

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M base/files/file.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/files/file.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M base/files/file_posix.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M base/files/file_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M base/files/file_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rvargas (doing something else)
Please take a look.
6 years, 11 months ago (2014-01-08 19:09:52 UTC) #1
Nico
lgtm, thanks
6 years, 11 months ago (2014-01-08 19:11:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/126453004/1
6 years, 11 months ago (2014-01-08 20:27:22 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 22:30:25 UTC) #4
Message was sent while issue was closed.
Change committed as 243676

Powered by Google App Engine
This is Rietveld 408576698