Base: Rename File::error() to File::error_details()

base/files/file_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/files/file.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/time/time.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using base::File;
 using base::FilePath;
 
 TEST(File, Create) {
   base::ScopedTempDir temp_dir;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
   FilePath file_path = temp_dir.path().AppendASCII("create_file_1");
 
   {
     // Open a file that doesn't exist.
     File file(file_path, base::File::FLAG_OPEN | base::File::FLAG_READ);
     EXPECT_FALSE(file.IsValid());
-    EXPECT_EQ(base::File::FILE_ERROR_NOT_FOUND, file.error());
+    EXPECT_EQ(base::File::FILE_ERROR_NOT_FOUND, file.error_details());
   }
 
   {
     // Open or create a file.
     File file(file_path, base::File::FLAG_OPEN_ALWAYS | base::File::FLAG_READ);
     EXPECT_TRUE(file.IsValid());
     EXPECT_TRUE(file.created());
-    EXPECT_EQ(base::File::FILE_OK, file.error());
+    EXPECT_EQ(base::File::FILE_OK, file.error_details());
   }
 
   {
     // Open an existing file.
     File file(file_path, base::File::FLAG_OPEN | base::File::FLAG_READ);
     EXPECT_TRUE(file.IsValid());
     EXPECT_FALSE(file.created());
-    EXPECT_EQ(base::File::FILE_OK, file.error());
+    EXPECT_EQ(base::File::FILE_OK, file.error_details());
 
     // This time verify closing the file.
     file.Close();
     EXPECT_FALSE(file.IsValid());
   }
 
   {
     // Open an existing file through Initialize
     File file;
     file.Initialize(file_path, base::File::FLAG_OPEN | base::File::FLAG_READ);
     EXPECT_TRUE(file.IsValid());
     EXPECT_FALSE(file.created());
-    EXPECT_EQ(base::File::FILE_OK, file.error());
+    EXPECT_EQ(base::File::FILE_OK, file.error_details());
 
     // This time verify closing the file.
     file.Close();
     EXPECT_FALSE(file.IsValid());
   }
 
   {
     // Create a file that exists.
     File file(file_path, base::File::FLAG_CREATE | base::File::FLAG_READ);
     EXPECT_FALSE(file.IsValid());
     EXPECT_FALSE(file.created());
-    EXPECT_EQ(base::File::FILE_ERROR_EXISTS, file.error());
+    EXPECT_EQ(base::File::FILE_ERROR_EXISTS, file.error_details());
   }
 
   {
     // Create or overwrite a file.
     File file(file_path,
               base::File::FLAG_CREATE_ALWAYS | base::File::FLAG_READ);
     EXPECT_TRUE(file.IsValid());
     EXPECT_TRUE(file.created());
-    EXPECT_EQ(base::File::FILE_OK, file.error());
+    EXPECT_EQ(base::File::FILE_OK, file.error_details());
   }
 
   {
     // Create a delete-on-close file.
     file_path = temp_dir.path().AppendASCII("create_file_2");
     File file(file_path,
               base::File::FLAG_OPEN_ALWAYS | base::File::FLAG_READ |
                   base::File::FLAG_DELETE_ON_CLOSE);
     EXPECT_TRUE(file.IsValid());
     EXPECT_TRUE(file.created());
-    EXPECT_EQ(base::File::FILE_OK, file.error());
+    EXPECT_EQ(base::File::FILE_OK, file.error_details());
   }
 
   EXPECT_FALSE(base::PathExists(file_path));
 }
 
 TEST(File, DeleteOpenFile) {
   base::ScopedTempDir temp_dir;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
   FilePath file_path = temp_dir.path().AppendASCII("create_file_1");
 
   // Create a file.
   File file(file_path,
             base::File::FLAG_OPEN_ALWAYS | base::File::FLAG_READ |
                 base::File::FLAG_SHARE_DELETE);
   EXPECT_TRUE(file.IsValid());
   EXPECT_TRUE(file.created());
-  EXPECT_EQ(base::File::FILE_OK, file.error());
+  EXPECT_EQ(base::File::FILE_OK, file.error_details());
 
   // Open an existing file and mark it as delete on close.
   File same_file(file_path,
                  base::File::FLAG_OPEN | base::File::FLAG_DELETE_ON_CLOSE |
                      base::File::FLAG_READ);
   EXPECT_TRUE(file.IsValid());
   EXPECT_FALSE(same_file.created());
-  EXPECT_EQ(base::File::FILE_OK, same_file.error());
+  EXPECT_EQ(base::File::FILE_OK, same_file.error_details());
 
   // Close both handles and check that the file is gone.
   file.Close();
   same_file.Close();
   EXPECT_FALSE(base::PathExists(file_path));
 }
 
 TEST(File, ReadWrite) {
   base::ScopedTempDir temp_dir;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
@@ skipping 272 matching lines @@
                    NULL));
   ASSERT_TRUE(dir.IsValid());
 
   base::File::Info info;
   EXPECT_TRUE(dir.GetInfo(&info));
   EXPECT_TRUE(info.is_directory);
   EXPECT_FALSE(info.is_symbolic_link);
   EXPECT_EQ(0, info.size);
 }
 #endif  // defined(OS_WIN)