Source/core/loader/DocumentThreadableLoader.h - Issue 1264453002: Split the constructor of ThreadableLoader into two methods (ctor and start())

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/DocumentThreadableLoader.h

Issue 1264453002: Split the constructor of ThreadableLoader into two methods (ctor and start()) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed #7. Rebased Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/security/mixedContent/insecure-async-post-xhr-blocked.html ('K') | « Source/core/fileapi/FileReaderLoader.cpp ('k') | Source/core/loader/DocumentThreadableLoader.cpp » ('j') | Source/core/loader/ThreadableLoader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/loader/DocumentThreadableLoader.h

diff --git a/Source/core/loader/DocumentThreadableLoader.h b/Source/core/loader/DocumentThreadableLoader.h

index b5b9d9d9d53c546e69326c67511603dbf2777e1c..66a2453c68e4bd79d628549945de558194bcef04 100644

--- a/Source/core/loader/DocumentThreadableLoader.h

+++ b/Source/core/loader/DocumentThreadableLoader.h

@@ -57,9 +57,11 @@ class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader, priv

WTF_MAKE_FAST_ALLOCATED(DocumentThreadableLoader);

public:

static void loadResourceSynchronously(Document&, const ResourceRequest&, ThreadableLoaderClient&, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);

- static PassRefPtr<DocumentThreadableLoader> create(Document&, ThreadableLoaderClient*, const ResourceRequest&, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);

+ static PassRefPtr<DocumentThreadableLoader> create(Document&, ThreadableLoaderClient*, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);

~DocumentThreadableLoader() override;

+ void start(const ResourceRequest&) override;

void overrideTimeout(unsigned long timeout) override;

void cancel() override;

@@ -71,7 +73,7 @@ class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader, priv

LoadAsynchronously

};

- DocumentThreadableLoader(Document&, ThreadableLoaderClient*, BlockingBehavior, const ResourceRequest&, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);

+ DocumentThreadableLoader(Document&, ThreadableLoaderClient*, BlockingBehavior, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);

// ResourceClient

void notifyFinished(Resource*) override;

@@ -149,7 +151,7 @@ class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader, priv

const bool m_async;

// Holds the original request context (used for sanity checks).

- const WebURLRequest::RequestContext m_requestContext;

+ WebURLRequest::RequestContext m_requestContext;

// Holds the original request for fallback in case the Service Worker

// does not respond.