Source/core/fileapi/FileReaderLoader.cpp - Issue 1264453002: Split the constructor of ThreadableLoader into two methods (ctor and start())

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/fileapi/FileReaderLoader.cpp

Issue 1264453002: Split the constructor of ThreadableLoader into two methods (ctor and start()) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed #7. Rebased Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/security/mixedContent/insecure-async-post-xhr-blocked.html ('K') | « LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-async-xhr-post.html ('k') | Source/core/loader/DocumentThreadableLoader.h » ('j') | Source/core/loader/ThreadableLoader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/fileapi/FileReaderLoader.cpp

diff --git a/Source/core/fileapi/FileReaderLoader.cpp b/Source/core/fileapi/FileReaderLoader.cpp

index c94cacd8d597499d2f42c602f25111d4347c3f8d..9e4bca6104e1e5e611e44f48a71c1927da5d6300 100644

--- a/Source/core/fileapi/FileReaderLoader.cpp

+++ b/Source/core/fileapi/FileReaderLoader.cpp

@@ -119,10 +119,12 @@ void FileReaderLoader::startInternal(ExecutionContext& executionContext, const S

ResourceLoaderOptions resourceLoaderOptions;

resourceLoaderOptions.allowCredentials = AllowStoredCredentials;

- if (m_client)

- m_loader = ThreadableLoader::create(executionContext, this, request, options, resourceLoaderOptions);

- else

+ if (m_client) {

+ m_loader = ThreadableLoader::create(executionContext, this, options, resourceLoaderOptions);

+ m_loader->start(request);

+ } else {

ThreadableLoader::loadResourceSynchronously(executionContext, request, *this, options, resourceLoaderOptions);

+ }

}

void FileReaderLoader::start(ExecutionContext* executionContext, PassRefPtr<BlobDataHandle> blobData)