Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

Issue 1264453002: Split the constructor of ThreadableLoader into two methods (ctor and start()) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed pipes around non-variables in a comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h
diff --git a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h
index b46bc61ccf5d384e6e6524e25acc6771c22b0681..0725043a10cbe30295df6d48aeb9379caf8482a9 100644
--- a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h
+++ b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h
@@ -57,9 +57,11 @@ class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader, priv
USING_FAST_MALLOC(DocumentThreadableLoader);
public:
static void loadResourceSynchronously(Document&, const ResourceRequest&, ThreadableLoaderClient&, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);
- static PassRefPtr<DocumentThreadableLoader> create(Document&, ThreadableLoaderClient*, const ResourceRequest&, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);
+ static PassRefPtr<DocumentThreadableLoader> create(Document&, ThreadableLoaderClient*, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);
~DocumentThreadableLoader() override;
+ void start(const ResourceRequest&) override;
+
void overrideTimeout(unsigned long timeout) override;
// |this| may be dead after calling this method in async mode.
@@ -72,7 +74,7 @@ class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader, priv
LoadAsynchronously
};
- DocumentThreadableLoader(Document&, ThreadableLoaderClient*, BlockingBehavior, const ResourceRequest&, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);
+ DocumentThreadableLoader(Document&, ThreadableLoaderClient*, BlockingBehavior, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);
void clear();
@@ -198,7 +200,7 @@ class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader, priv
const bool m_async;
// Holds the original request context (used for sanity checks).
- const WebURLRequest::RequestContext m_requestContext;
+ WebURLRequest::RequestContext m_requestContext;
// Holds the original request for fallback in case the Service Worker
// does not respond.
@@ -220,7 +222,7 @@ class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader, priv
// because same-origin redirects are not counted here.
int m_corsRedirectLimit;
- const WebURLRequest::FetchRedirectMode m_redirectMode;
+ WebURLRequest::FetchRedirectMode m_redirectMode;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698