third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp - Issue 1264453002: Split the constructor of ThreadableLoader into two methods (ctor and start())

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp

Issue 1264453002: Split the constructor of ThreadableLoader into two methods (ctor and start()) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed pipes around non-variables in a comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-fetch.html ('k') | third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp

diff --git a/third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp b/third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp

index ad5761fd0048d41a42dbb094fdc5c28305f37ab6..bf1a6f63a332c986f29e800a7ecc840dcf6ad699 100644

--- a/third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp

+++ b/third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp

@@ -117,10 +117,12 @@ void FileReaderLoader::startInternal(ExecutionContext& executionContext, const S

ResourceLoaderOptions resourceLoaderOptions;

resourceLoaderOptions.allowCredentials = AllowStoredCredentials;

- if (m_client)

- m_loader = ThreadableLoader::create(executionContext, this, request, options, resourceLoaderOptions);

- else

+ if (m_client) {

+ m_loader = ThreadableLoader::create(executionContext, this, options, resourceLoaderOptions);

+ m_loader->start(request);

+ } else {

ThreadableLoader::loadResourceSynchronously(executionContext, request, *this, options, resourceLoaderOptions);

+ }

}

void FileReaderLoader::start(ExecutionContext* executionContext, PassRefPtr<BlobDataHandle> blobData)