Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp

Issue 1264453002: Split the constructor of ThreadableLoader into two methods (ctor and start()) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp b/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp
index b79f4ea2e6f87910c434df582563b098a14f3e1b..6ea5fa68bcd63924f71d9f36ad63a85c8ba66cde 100644
--- a/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp
+++ b/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp
@@ -45,6 +45,7 @@ String toString(const Vector<char>& data)
class NoopLoader final : public ThreadableLoader {
public:
static PassRefPtr<ThreadableLoader> create() { return adoptRef(new NoopLoader); }
+ void start(const ResourceRequest&) override {}
void overrideTimeout(unsigned long) override {}
void cancel() override {}
};
@@ -52,7 +53,7 @@ public:
class LoaderFactory : public FetchBlobDataConsumerHandle::LoaderFactory {
public:
explicit LoaderFactory(PassOwnPtr<WebDataConsumerHandle> handle) : m_handle(handle) {}
- PassRefPtr<ThreadableLoader> create(ExecutionContext&, ThreadableLoaderClient* client, const ResourceRequest&, const ThreadableLoaderOptions&, const ResourceLoaderOptions&) override
+ PassRefPtr<ThreadableLoader> create(ExecutionContext&, ThreadableLoaderClient* client, const ThreadableLoaderOptions&, const ResourceLoaderOptions&) override
{
RefPtr<ThreadableLoader> loader = NoopLoader::create();
client->didReceiveResponse(0, ResourceResponse(), m_handle.release());
hiroshige 2016/01/26 08:44:50 Please call didReceiveResponse() in NoopLoader::st
tyoshino (SeeGerritForStatus) 2016/01/29 12:36:52 Oh, good point. Fixed.

Powered by Google App Engine
This is Rietveld 408576698