Split the constructor of ThreadableLoader into two methods (ctor and start())

third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/fetch/FetchFormDataConsumerHandle.h"
 
 #include "core/dom/DOMTypedArray.h"
 #include "core/html/FormData.h"
 #include "core/loader/ThreadableLoader.h"
 #include "core/loader/ThreadableLoaderClient.h"
@@ skipping 27 matching lines @@
 using Command = DataConsumerHandleTestUtil::Command;
 
 String toString(const Vector<char>& data)
 {
     return String(data.data(), data.size());
 }
 
 class NoopLoader final : public ThreadableLoader {
 public:
     static PassRefPtr<ThreadableLoader> create() { return adoptRef(new NoopLoader); }
+    void start(const ResourceRequest&) override {}
     void overrideTimeout(unsigned long) override {}
     void cancel() override {}
 };
 
 class LoaderFactory : public FetchBlobDataConsumerHandle::LoaderFactory {
 public:
     explicit LoaderFactory(PassOwnPtr<WebDataConsumerHandle> handle) : m_handle(handle) {}
-    PassRefPtr<ThreadableLoader> create(ExecutionContext&, ThreadableLoaderClient* client, const ResourceRequest&, const ThreadableLoaderOptions&, const ResourceLoaderOptions&) override
+    PassRefPtr<ThreadableLoader> create(ExecutionContext&, ThreadableLoaderClient* client, const ThreadableLoaderOptions&, const ResourceLoaderOptions&) override
     {
         RefPtr<ThreadableLoader> loader = NoopLoader::create();
         client->didReceiveResponse(0, ResourceResponse(), m_handle.release());

[hiroshige, 2016/01/26 08:44:50]

Please call didReceiveResponse() in NoopLoader::start(), since we'll move
ThreadableLoaderClient method calls from create() to start() in this CL.

[tyoshino (SeeGerritForStatus), 2016/01/29 12:36:52]

Oh, good point. Fixed.

         return loader.release();
     }
 
 private:
     OwnPtr<WebDataConsumerHandle> m_handle;
 };
 
 class FetchFormDataConsumerHandleTest : public ::testing::Test {
 public:
     FetchFormDataConsumerHandleTest() : m_page(DummyPageHolder::create(IntSize(1, 1))) {}
@@ skipping 359 matching lines @@
     EXPECT_EQ(kShouldWait, reader->beginRead(&buffer, kNone, &available));
     testing::runPendingTasks();
     EXPECT_EQ(kOk, reader->beginRead(&buffer, kNone, &available));
     EXPECT_FALSE(reader->drainAsFormData());
     reader->endRead(0);
     EXPECT_FALSE(reader->drainAsFormData());
 }
 
 } // namespace
 } // namespace blink