Reorganize to keep similar code together.

Reorganize to keep similar code together.

This organizes memset16, memset32, and rsqrt the same way as the other code.  No functional change.

BUG=skia:4117

[mtklein_C, 2015-08-04 16:51:42]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-04 16:51:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1264423002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1264423002/1

[commit-bot: I haz the power, 2015-08-04 16:53:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-04 16:53:38]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)

[mtklein_C, 2015-08-04 16:56:08]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-04 16:56:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1264423002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1264423002/20001

[mtklein_C, 2015-08-04 17:00:19]

mtklein@chromium.org changed reviewers:
+ djsollen@google.com

[mtklein_C, 2015-08-04 17:00:20]

An easy one!

[commit-bot: I haz the power, 2015-08-04 17:03:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-04 17:03:25]

Dry run: This issue passed the CQ dry run.

[djsollen, 2015-08-04 17:43:57]

1gtm after nit comment

https://codereview.chromium.org/1264423002/diff/20001/src/core/SkOpts.cpp
File src/core/SkOpts.cpp (right):

https://codereview.chromium.org/1264423002/diff/20001/src/core/SkOpts.cpp#new...
src/core/SkOpts.cpp:30: // Define default function pointer values here...
add comment that these may not be the actual portable code.

[djsollen, 2015-08-04 17:44:13]

lgtm

[mtklein, 2015-08-04 17:52:03]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2015-08-04 17:52:04]

https://codereview.chromium.org/1264423002/diff/20001/src/core/SkOpts.cpp
File src/core/SkOpts.cpp (right):

https://codereview.chromium.org/1264423002/diff/20001/src/core/SkOpts.cpp#new...
src/core/SkOpts.cpp:30: // Define default function pointer values here...
On 2015/08/04 17:43:57, djsollen wrote:
> add comment that these may not be the actual portable code.

Done.

[mtklein, 2015-08-04 17:52:07]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-08-04 17:52:07]

The patchset sent to the CQ was uploaded after l-g-t-m from djsollen@google.com
Link to the patchset: https://codereview.chromium.org/1264423002/#ps40001
(title: "note")

[commit-bot: I haz the power, 2015-08-04 17:52:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1264423002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1264423002/40001

[commit-bot: I haz the power, 2015-08-04 17:52:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-04 17:52:39]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[mtklein_C, 2015-08-04 19:49:52]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2015-08-04 19:50:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1264423002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1264423002/40001

[commit-bot: I haz the power, 2015-08-04 20:02:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-04 20:02:40]

Failed to commit the patch.

[borenet, 2015-08-04 20:08:08]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2015-08-04 20:08:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1264423002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1264423002/40001

[commit-bot: I haz the power, 2015-08-04 20:10:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-04 20:10:08]

Failed to commit the patch.

[borenet, 2015-08-04 20:11:44]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2015-08-04 20:11:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1264423002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1264423002/40001

[commit-bot: I haz the power, 2015-08-04 20:13:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-04 20:13:19]

Failed to commit the patch.

[commit-bot: I haz the power, 2015-08-04 20:13:20]

The CQ bit was unchecked by commit-bot@chromium.org

[mtklein_C, 2015-08-04 20:48:30]

The CQ bit was checked by mtklein@chromium.org

[mtklein_C, 2015-08-04 20:48:30]

The patchset sent to the CQ was uploaded after l-g-t-m from djsollen@google.com
Link to the patchset: https://codereview.chromium.org/1264423002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2015-08-04 20:48:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1264423002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1264423002/60001

[mtklein_C, 2015-08-04 20:48:47]

Committed patchset #4 (id:60001) manually as
8caa5af92cf91debc1598380cb72c330e8c63efb (presubmit successful).

[commit-bot: I haz the power, 2015-08-04 20:49:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-04 20:49:23]

Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)