Reorganize to keep similar code together.

src/core/SkOpts.cpp

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkOnce.h"
 #include "SkOpts.h"
+
 #define SK_OPTS_NS portable
 #include "SkBlurImageFilter_opts.h"
+#include "SkFloatingPoint_opts.h"
+#include "SkUtils_opts.h"
 #include "SkXfermode_opts.h"
 
 #if defined(SK_CPU_X86)
     #if defined(SK_BUILD_FOR_WIN32)
         #include <intrin.h>
         static void cpuid(uint32_t abcd[4]) { __cpuid((int*)abcd, 1); }
     #else
         #include <cpuid.h>
         static void cpuid(uint32_t abcd[4]) { __get_cpuid(1, abcd+0, abcd+1, abcd+2, abcd+3); }
     #endif
 #elif !defined(SK_ARM_HAS_NEON) && defined(SK_CPU_ARM32) && defined(SK_BUILD_FOR_ANDROID)
     #include <cpu-features.h>
 #endif
 
-namespace portable {  // This helps identify methods from this file when debugging / profiling.
-
-static float rsqrt(float x) {
-    // Get initial estimate.
-    int i = *SkTCast<int*>(&x);
-    i = 0x5F1FFFF9 - (i>>1);
-    float estimate = *SkTCast<float*>(&i);
-
-    // One step of Newton's method to refine.
-    const float estimate_sq = estimate*estimate;
-    estimate *= 0.703952253f*(2.38924456f-x*estimate_sq);
-    return estimate;
-}
-
-template <typename T>
-static void memsetT(T dst[], T val, int n) { while (n --> 0) { *dst++ = val; } }
-
-}  // namespace portable
-
 namespace SkOpts {
     // Define default function pointer values here...
+    // If our global compile options are set high enough, these 'portable' defaults might
+    // even be CPU-specialized, e.g. a typical x86-64 machine might start with SSE2 defaults.
+    // They'll still get a chance to be replaced with even better ones, e.g. using SSE4.1.
     decltype(rsqrt)                     rsqrt = portable::rsqrt;
-    decltype(memset16)               memset16 = portable::memsetT<uint16_t>;
-    decltype(memset32)               memset32 = portable::memsetT<uint32_t>;
+    decltype(memset16)               memset16 = portable::memset16;
+    decltype(memset32)               memset32 = portable::memset32;
     decltype(create_xfermode) create_xfermode = SkCreate4pxXfermode;
 
     static const auto x = portable::kX, y = portable::kY;
     decltype(box_blur_xx) box_blur_xx = portable::box_blur<x,x>;
     decltype(box_blur_xy) box_blur_xy = portable::box_blur<x,y>;
     decltype(box_blur_yx) box_blur_yx = portable::box_blur<y,x>;
 
     // Each Init_foo() is defined in src/opts/SkOpts_foo.cpp.
     void Init_sse2();
     void Init_ssse3();
@@ skipping 18 matching lines @@
 
     SK_DECLARE_STATIC_ONCE(gInitOnce);
     void Init() { SkOnce(&gInitOnce, init); }
 
 #if SK_ALLOW_STATIC_GLOBAL_INITIALIZERS
     static struct AutoInit {
         AutoInit() { Init(); }
     } gAutoInit;
 #endif
 }