Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Unified Diff: content/browser/service_worker/service_worker_metrics.h

Issue 1264333002: First step to refactor ServiceWorkerVersion to make event dispatching more modular. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rockot nits Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_metrics.h
diff --git a/content/browser/service_worker/service_worker_metrics.h b/content/browser/service_worker/service_worker_metrics.h
index ebf941d02c5dce50ebeb48e6e13fba80b7504956..a24dc25e9ab67fad772ebd7c633ca09a9df056be 100644
--- a/content/browser/service_worker/service_worker_metrics.h
+++ b/content/browser/service_worker/service_worker_metrics.h
@@ -72,11 +72,19 @@ class ServiceWorkerMetrics {
NUM_TYPES
};
- enum EventType {
- EVENT_TYPE_FETCH,
+ // Used for UMA. Append-only.
+ enum class EventType {
+ ACTIVATE,
+ INSTALL,
+ FETCH,
+ SYNC,
+ NOTIFICATION_CLICK,
+ PUSH,
+ GEOFENCING,
+ SERVICE_PORT_CONNECT,
// Add new events to record here.
- NUM_EVENT_TYPES
+ NUM_TYPES
};
// Used for UMA. Append only.
@@ -131,6 +139,9 @@ class ServiceWorkerMetrics {
size_t handled_events,
size_t fired_events);
+ // Records how often a dispatched event times out.
+ static void RecordEventTimeout(EventType event);
+
// Records the result of dispatching a fetch event to a service worker.
static void RecordFetchEventStatus(bool is_main_resource,
ServiceWorkerStatusCode status);

Powered by Google App Engine
This is Rietveld 408576698