Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: content/browser/service_worker/service_worker_metrics.cc

Issue 1264333002: First step to refactor ServiceWorkerVersion to make event dispatching more modular. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rockot nits Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_metrics.cc
diff --git a/content/browser/service_worker/service_worker_metrics.cc b/content/browser/service_worker/service_worker_metrics.cc
index a900d4dfd5527d14a5892f50a48f6772e69d8528..95206ad8dd3bd91dbb00f30ea7b5ea7453989c65 100644
--- a/content/browser/service_worker/service_worker_metrics.cc
+++ b/content/browser/service_worker/service_worker_metrics.cc
@@ -168,12 +168,20 @@ void ServiceWorkerMetrics::RecordEventHandledRatio(EventType event,
type = EVENT_HANDLED_ALL;
else if (handled_events == 0)
type = EVENT_HANDLED_NONE;
+
// For now Fetch is the only type that is recorded.
- DCHECK_EQ(EVENT_TYPE_FETCH, event);
+ if (event != EventType::FETCH)
+ return;
UMA_HISTOGRAM_ENUMERATION("ServiceWorker.EventHandledRatioType.Fetch", type,
NUM_EVENT_HANDLED_RATIO_TYPE);
}
+void ServiceWorkerMetrics::RecordEventTimeout(EventType event) {
+ UMA_HISTOGRAM_ENUMERATION("ServiceWorker.RequestTimeouts.Count",
+ static_cast<int>(event),
+ static_cast<int>(EventType::NUM_TYPES));
+}
+
void ServiceWorkerMetrics::RecordFetchEventStatus(
bool is_main_resource,
ServiceWorkerStatusCode status) {
« no previous file with comments | « content/browser/service_worker/service_worker_metrics.h ('k') | content/browser/service_worker/service_worker_provider_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698