Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 1264143002: Revert of Service Worker: Make ServiceWorkerRegistration.update() return a promise. (Blink 1/3) (Closed)

Created:
5 years, 4 months ago by johnme
Modified:
5 years, 4 months ago
CC:
blink-reviews, jsbell, tzik, serviceworker-reviews, dglazkov+blink, kinuko+serviceworker, horo
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Service Worker: Make ServiceWorkerRegistration.update() return a promise. (Blink 1/3) (patchset #2 id:20001 of https://codereview.chromium.org/1267703003/) Reason for revert: Sorry, this seems to cause http/tests/serviceworker/update.html to fail consistently on WebKit Linux Leak and WebKit Linux Oilpan Leak with the following error: (leak detected: ({"numberOfLiveActiveDOMObjects":[2,3]})) See flakiness dashboard: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fserviceworker%2Fupdate.html&testType=layout-tests And example failed build: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/12981 Original issue's description: > Service Worker: Make ServiceWorkerRegistration.update() return a promise. (Blink 1/3) > > As per the resolution of f2f, ServiceWorkerRegistration.update() should return a > promise that transforms the promise returned by Update algorithm. > > In this CL, ServiceWorkerContextCore::UpdateServiceWorker method has been > overloaded to cover two invocation paths: a scheduled update without a > provider_host and a callback (Soft Update in the spec) and a call initiated from > the script surface using ServiceWorkerRegistration.update(). > > This is a web-exposed API change. But it has no compatibility risk because > existing user code doesn't expect to receive anything from update(). > > Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#service-worker-registration-update > Spec discussion: https://github.com/slightlyoff/ServiceWorker/issues/311 > > Companion CL (Chromium): https://codereview.chromium.org/1270513002/ > Companion CL (Blink layout test): https://codereview.chromium.org/1268663003/ > > BUG=513655 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199814 TBR=l.gombos@samsung.com,jinho.bang@samsung.com,falken@chromium.org,kinuko@chromium.org,nhiroki@chromium.org,michaeln@chromium.org,tkent@chromium.org,jungkee.song@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=513655 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199830

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -19 lines) Patch
M Source/modules/serviceworkers/ServiceWorkerRegistration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerRegistration.cpp View 1 chunk +4 lines, -9 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerRegistration.idl View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebServiceWorkerRegistration.h View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
johnme
Created Revert of Service Worker: Make ServiceWorkerRegistration.update() return a promise. (Blink 1/3)
5 years, 4 months ago (2015-07-31 13:25:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264143002/1
5 years, 4 months ago (2015-07-31 13:26:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=199830
5 years, 4 months ago (2015-07-31 13:26:50 UTC) #3
tkent
5 years, 4 months ago (2015-08-02 23:17:52 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698