[Android] Enable session invalidations while the RecentTabsPage is open

[Android] Enable session invalidations while the RecentTabsPage is open

The "AndroidSessionNotifications" experiment disables session invalidations
because session sync invalidations represent the bulk of the invalidation
traffic. Session invalidations cause the client to fetch the updated
"Recent Tabs" from the sync server.

This CL enables session sync invalidations only after the user has had the
RecentTabsPage open for a while. This enables the Android RecentTabsPage to be
"live": If a user opens a tab on a device which is signed in to the same profile
as the Android device, the RecentTabsPage on the Android device is updated with
the new tab. The CL disables session sync when the RecentTabsPage is closed
because the invalidations are not longer useful at that time.

BUG=477054
TEST=InvalidationControllerTest.*

Committed: https://crrev.com/531f0b72e8f506a55f91de42a7fa86bde4ca4e64
Cr-Commit-Position: refs/heads/master@{#342363}

[pkotwicz, 2015-08-03 01:31:14]

pkotwicz@chromium.org changed reviewers:
+ nyquist@chromium.org

[pkotwicz, 2015-08-03 01:33:38]

Tommy can you please take a look? Sorry that it took me this long to write the
CL

[nyquist, 2015-08-03 20:22:48]

Related change: https://codereview.chromium.org/1247853007/

[nyquist, 2015-08-03 23:22:18]

lgtm

https://codereview.chromium.org/1263773007/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java
(right):

https://codereview.chromium.org/1263773007/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java:111:
private static final int REGISTER_FOR_SESSION_SYNC_INVALIDATIONS_DELAY_MS =
30000;
How did you decide on this number? Any UMA-stat you could refer to here (not
numbers, but just the name of the interesting histogram?)

https://codereview.chromium.org/1263773007/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java:118:
private static final int UNREGISTER_FOR_SESSION_SYNC_INVALIDATIONS_DELAY_MS =
3600000; // 1hr
How did you decide on this number?

https://codereview.chromium.org/1263773007/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java:131:
private boolean mStarted;
What is started? (comment)

https://codereview.chromium.org/1263773007/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java:154:
// Do not apply changes to {@link mSessionInvalidationsEnabled} yet because the
timer task
Nit: Missing # before mSess...

https://codereview.chromium.org/1263773007/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java
(left):

https://codereview.chromium.org/1263773007/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java:116:
if (mProfileDataCache != null) {
Why was this removed?

https://codereview.chromium.org/1263773007/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/invalidations/InvalidationControllerTest.java
(right):

https://codereview.chromium.org/1263773007/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/invalidations/InvalidationControllerTest.java:433:
private IntentType getIntentType(Intent intent) {
Nit: static?

https://codereview.chromium.org/1263773007/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/invalidations/InvalidationControllerTest.java:447:
private Set<String> getRegisterIntentRegisterTypes(Intent intent) {
Nit: static?

[pkotwicz, 2015-08-05 00:13:12]

Tommy do you have any suggestions for
REGISTER_FOR_SESSION_SYNC_INVALIDATIONS_DELAY_MS and
UNREGISTER_FOR_SESSION_SYNC_INVALIDATIONS_DELAY_MS. I picked the values for this
CL mostly randomly

https://codereview.chromium.org/1263773007/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java
(right):

https://codereview.chromium.org/1263773007/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java:111:
private static final int REGISTER_FOR_SESSION_SYNC_INVALIDATIONS_DELAY_MS =
30000;
I picked this number semi-randomly. 96.5% of users have the RecentTabsPage open
for less than 30 seconds

https://codereview.chromium.org/1263773007/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java:118:
private static final int UNREGISTER_FOR_SESSION_SYNC_INVALIDATIONS_DELAY_MS =
3600000; // 1hr
I picked this number randomly. Do you have suggestions for a better value?

[pkotwicz, 2015-08-07 15:38:53]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2015-08-07 15:38:54]

The patchset sent to the CQ was uploaded after l-g-t-m from nyquist@chromium.org
Link to the patchset: https://codereview.chromium.org/1263773007/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-08-07 15:39:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1263773007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1263773007/60001

[commit-bot: I haz the power, 2015-08-07 16:15:30]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-08-07 16:16:07]

Patchset 4 (id:??) landed as
https://crrev.com/531f0b72e8f506a55f91de42a7fa86bde4ca4e64
Cr-Commit-Position: refs/heads/master@{#342363}