chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java - Issue 1263773007: [Android] Enable session invalidations while the RecentTabsPage is open

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java

Issue 1263773007: [Android] Enable session invalidations while the RecentTabsPage is open (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/invalidation/InvalidationControllerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java

index 24b264abdfcbdc3a3603c0a1e6c001e3f80cc9d8..687322196861f3575cea7cd1c9d092c9e60201a5 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java

@@ -13,6 +13,7 @@ import org.chromium.chrome.browser.UrlConstants;

import org.chromium.chrome.browser.favicon.FaviconHelper;

import org.chromium.chrome.browser.favicon.FaviconHelper.FaviconImageCallback;

import org.chromium.chrome.browser.firstrun.ProfileDataCache;

+import org.chromium.chrome.browser.invalidation.InvalidationController;

import org.chromium.chrome.browser.ntp.ForeignSessionHelper.ForeignSession;

import org.chromium.chrome.browser.ntp.ForeignSessionHelper.ForeignSessionCallback;

import org.chromium.chrome.browser.ntp.ForeignSessionHelper.ForeignSessionTab;

@@ -88,6 +89,8 @@ public class RecentTabsManager implements AndroidSyncSettingsObserver, SignInSta

updateForeignSessions();

mForeignSessionHelper.triggerSessionSync();

registerForSignInAndSyncNotifications();

+ InvalidationController.get(mContext).onRecentTabsPageOpened();

}

/**

@@ -117,6 +120,8 @@ public class RecentTabsManager implements AndroidSyncSettingsObserver, SignInSta

mProfileDataCache.destroy();

mProfileDataCache = null;

}

+ InvalidationController.get(mContext).onRecentTabsPageClosed();

}

private static ForeignSessionHelper buildForeignSessionHelper(Profile profile) {