Issue 1263593003: restore arrow function bind this workaround

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1263593003: restore arrow function bind this workaround (Closed)

Created:
5 years, 4 months ago by Jennifer Messerly

Modified:
5 years, 4 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org, ochafik

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+182 lines, -138 lines)			Patch
M	lib/runtime/dart/_isolate_helper.js	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	lib/runtime/dart/async.js	View		11 chunks	+31 lines, -31 lines	0 comments	Download
M	lib/runtime/dart/collection.js	View		10 chunks	+15 lines, -15 lines	0 comments	Download
M	lib/runtime/dart/convert.js	View		11 chunks	+22 lines, -22 lines	0 comments	Download
M	lib/runtime/dart/isolate.js	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	lib/src/codegen/js_codegen.dart	View		3 chunks	+4 lines, -14 lines	0 comments	Download
M	lib/src/codegen/js_printer.dart	View	1	1 chunk	+24 lines, -23 lines	0 comments	Download
M	lib/src/js/nodes.dart	View		5 chunks	+31 lines, -8 lines	0 comments	Download
M	lib/src/js/precedence.dart	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	lib/src/js/printer.dart	View	1	4 chunks	+19 lines, -3 lines	0 comments	Download
M	lib/src/options.dart	View		3 chunks	+10 lines, -3 lines	0 comments	Download
M	tool/build_sdk.sh	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	tool/input_sdk/private/js_mirrors.dart	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	tool/sdk_expected_errors.txt	View		1 chunk	+6 lines, -6 lines	0 comments	Download

Total messages: 4 (1 generated)

Jennifer Messerly

5 years, 4 months ago (2015-07-28 21:51:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
42df5583bda1170b4248fe0855e08766503d3c5d (presubmit successful).