Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: lib/src/js/precedence.dart

Issue 1263593003: restore arrow function bind this workaround (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/js/nodes.dart ('k') | lib/src/js/printer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/js/precedence.dart
diff --git a/lib/src/js/precedence.dart b/lib/src/js/precedence.dart
index 4b274ca649c2ccb065e7c1da50703948deb0f42c..13e8bd66c24c5dedbc07d48f86203503509f9b87 100644
--- a/lib/src/js/precedence.dart
+++ b/lib/src/js/precedence.dart
@@ -7,6 +7,16 @@ library precedence;
const EXPRESSION = 0;
const SPREAD = EXPRESSION + 1;
const YIELD = SPREAD + 1;
+
+// Note that some primary expressions (in the parser) must be emitted with lower
+// precedence, because it's not normally legal for them to be followed by
+// other postfix expressions, like ACCESS and CALL. For example:
+// `function foo(){}` needs parens to call or access properties or
+// compare with equality. Same thing with `class Foo {}` and `(x) => x`.
+// However, prefix unary expressions will work in these cases. Unfortunately our
+// current precedence tracking doesn't capture this distinction.
+const PRIMARY_LOW_PRECEDENCE = ASSIGNMENT;
+
const ASSIGNMENT = YIELD + 1;
const LOGICAL_OR = ASSIGNMENT + 1;
const LOGICAL_AND = LOGICAL_OR + 1;
« no previous file with comments | « lib/src/js/nodes.dart ('k') | lib/src/js/printer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698