Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 1263583005: implement exports, fixes #141 (Closed)

Created:
5 years, 4 months ago by Jennifer Messerly
Modified:
5 years, 4 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : rebase #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+612 lines, -397 lines) Patch
M lib/runtime/dart/_js_mirrors.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart_runtime.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart_utils.js View 3 chunks +28 lines, -28 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 8 chunks +96 lines, -28 lines 1 comment Download
M lib/src/codegen/js_printer.dart View 2 chunks +7 lines, -1 line 0 comments Download
M lib/src/js/nodes.dart View 1 chunk +6 lines, -1 line 0 comments Download
M lib/src/js/printer.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M test/browser/language_tests.js View 1 chunk +15 lines, -0 lines 0 comments Download
M test/codegen/expect/dir/html_input_b.js View 1 chunk +4 lines, -2 lines 0 comments Download
M test/codegen/expect/js_test.txt View 1 chunk +249 lines, -249 lines 0 comments Download
A test/codegen/expect/script.js View 1 chunk +18 lines, -0 lines 2 comments Download
A test/codegen/expect/script.txt View 1 chunk +1 line, -0 lines 0 comments Download
M test/codegen/expect/sunflower/sunflower.html View 1 chunk +1 line, -1 line 0 comments Download
A + test/codegen/language/duplicate_export_liba.dart View 1 chunk +4 lines, -5 lines 0 comments Download
A test/codegen/language/duplicate_export_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A + test/codegen/language/duplicate_import_liba.dart View 1 chunk +8 lines, -5 lines 0 comments Download
A + test/codegen/language/export_cyclic_helper1.dart View 1 chunk +10 lines, -5 lines 0 comments Download
A + test/codegen/language/export_cyclic_helper2.dart View 1 chunk +12 lines, -5 lines 0 comments Download
A + test/codegen/language/export_cyclic_helper3.dart View 1 chunk +2 lines, -5 lines 0 comments Download
A test/codegen/language/export_cyclic_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download
A + test/codegen/language/export_double_same_main_test.dart View 1 chunk +3 lines, -5 lines 0 comments Download
A + test/codegen/language/export_helper1.dart View 1 chunk +7 lines, -5 lines 0 comments Download
A + test/codegen/language/export_helper2.dart View 1 chunk +4 lines, -5 lines 0 comments Download
A + test/codegen/language/export_helper3.dart View 1 chunk +7 lines, -5 lines 0 comments Download
A + test/codegen/language/export_helper4.dart View 1 chunk +4 lines, -5 lines 0 comments Download
A + test/codegen/language/export_main_override_test.dart View 1 chunk +6 lines, -5 lines 0 comments Download
A + test/codegen/language/export_main_test.dart View 1 chunk +2 lines, -4 lines 0 comments Download
A test/codegen/language/export_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A + test/codegen/language/local_export_a.dart View 1 chunk +6 lines, -5 lines 0 comments Download
A + test/codegen/language/local_export_a_export.dart View 1 chunk +2 lines, -5 lines 0 comments Download
A + test/codegen/language/local_export_test.dart View 1 chunk +6 lines, -5 lines 0 comments Download
A + test/codegen/language/reexport_core_helper.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A test/codegen/language/reexport_core_test.dart View 1 chunk +21 lines, -0 lines 0 comments Download
A + test/codegen/language/top_level_entry.dart View 1 chunk +4 lines, -3 lines 0 comments Download
A + test/codegen/language/top_level_entry_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
A test/codegen/script.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M tool/input_sdk/private/js_mirrors.dart View 1 chunk +1 line, -1 line 0 comments Download
M tool/sdk_expected_errors.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
https://codereview.chromium.org/1263583005/diff/20001/lib/src/codegen/js_codegen.dart File lib/src/codegen/js_codegen.dart (left): https://codereview.chromium.org/1263583005/diff/20001/lib/src/codegen/js_codegen.dart#oldcode133 lib/src/codegen/js_codegen.dart:133: // TODO(jmesserly): visit scriptTag, directives? went ahead and fixed ...
5 years, 4 months ago (2015-08-03 21:11:50 UTC) #3
vsm
lgtm https://codereview.chromium.org/1263583005/diff/20001/test/codegen/expect/script.js File test/codegen/expect/script.js (right): https://codereview.chromium.org/1263583005/diff/20001/test/codegen/expect/script.js#newcode1 test/codegen/expect/script.js:1: #!/usr/bin/env iojs cute :-) Does this actually work? ...
5 years, 4 months ago (2015-08-04 23:49:58 UTC) #4
Jennifer Messerly
https://codereview.chromium.org/1263583005/diff/20001/test/codegen/expect/script.js File test/codegen/expect/script.js (right): https://codereview.chromium.org/1263583005/diff/20001/test/codegen/expect/script.js#newcode1 test/codegen/expect/script.js:1: #!/usr/bin/env iojs On 2015/08/04 23:49:58, vsm wrote: > cute ...
5 years, 4 months ago (2015-08-04 23:58:40 UTC) #5
Jennifer Messerly
5 years, 4 months ago (2015-08-05 00:23:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
ce68cfa4f09dd601621914d14b3daba75486f3e6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698