tool/input_sdk/private/js_mirrors.dart - Issue 1263583005: implement exports, fixes #141

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tool/input_sdk/private/js_mirrors.dart

Issue 1263583005: implement exports, fixes #141 (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tool/input_sdk/private/js_mirrors.dart

diff --git a/tool/input_sdk/private/js_mirrors.dart b/tool/input_sdk/private/js_mirrors.dart

index 92aecdb7e3d622e4955f7b786d5444133f863234..cc50f43c0a7e11162ce905ae0de8a186d4fb3586 100644

--- a/tool/input_sdk/private/js_mirrors.dart

+++ b/tool/input_sdk/private/js_mirrors.dart

@@ -108,7 +108,7 @@ class JsClassMirror implements ClassMirror {

// TODO(vsm): Support named constructors and named arguments.

assert(getName(constructorName) == "");

assert(namedArgs == null || namedArgs.isEmpty);

- var instance = JS('', '#.instantiate(#, #)', _dart, _cls, args);

+ var instance = JS('', 'new #(...#)', _cls, args);

return new JsInstanceMirror._(instance);

}