Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1263513004: Get content_unittests to link on the mac GN build. (Closed)

Created:
5 years, 4 months ago by Dirk Pranke
Modified:
5 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@enable_mac_net_unittests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get content_unittests to link on the mac GN build. This fixes dependencies for the mac cups and sanbox libraries, and adds a missing dependency on //ui/compositor:test_support. R=brettw@chromium.org BUG=431177 CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/517335eb07aa66d7d276a61c4c9945223cb0bb9e Cr-Commit-Position: refs/heads/master@{#341458}

Patch Set 1 #

Total comments: 2

Patch Set 2 : merge to #341417 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M printing/BUILD.gn View 1 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
Dirk Pranke
https://codereview.chromium.org/1263513004/diff/1/printing/BUILD.gn File printing/BUILD.gn (right): https://codereview.chromium.org/1263513004/diff/1/printing/BUILD.gn#newcode230 printing/BUILD.gn:230: lib_dirs = [ "$mac_sdk_path/usr/lib" ] I think using ldflags ...
5 years, 4 months ago (2015-07-31 19:58:34 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263513004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263513004/1
5 years, 4 months ago (2015-07-31 20:04:40 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/80439) mac_chromium_rel_ng on ...
5 years, 4 months ago (2015-07-31 20:07:42 UTC) #5
brettw
lgtm https://codereview.chromium.org/1263513004/diff/1/printing/BUILD.gn File printing/BUILD.gn (right): https://codereview.chromium.org/1263513004/diff/1/printing/BUILD.gn#newcode230 printing/BUILD.gn:230: lib_dirs = [ "$mac_sdk_path/usr/lib" ] On 2015/07/31 19:58:34, ...
5 years, 4 months ago (2015-07-31 21:35:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263513004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263513004/20001
5 years, 4 months ago (2015-08-01 02:09:30 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-01 02:41:21 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-01 02:41:52 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/517335eb07aa66d7d276a61c4c9945223cb0bb9e
Cr-Commit-Position: refs/heads/master@{#341458}

Powered by Google App Engine
This is Rietveld 408576698