Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1256693004: Build net_unittests in Mac GN. (Closed)

Created:
5 years, 4 months ago by Dirk Pranke
Modified:
5 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@update_mac_build
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build net_unittests in Mac GN. At some point this wasn't working, but it seems to work fine now. R=brettw@chromium.org BUG=513775 CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/64df28358d9c22a7ae4e3b2fe229de37c974d180 Cr-Commit-Position: refs/heads/master@{#341428}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove duplicated balsa dep #

Patch Set 3 : merge to #341417 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -304 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M net/BUILD.gn View 1 2 1 chunk +301 lines, -303 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256693004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256693004/1
5 years, 4 months ago (2015-07-31 19:22:20 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-31 19:51:22 UTC) #4
brettw
lgtm https://codereview.chromium.org/1256693004/diff/1/net/BUILD.gn File net/BUILD.gn (right): https://codereview.chromium.org/1256693004/diff/1/net/BUILD.gn#newcode1367 net/BUILD.gn:1367: ":balsa", I noticed this is duplicated above. Can ...
5 years, 4 months ago (2015-07-31 21:32:21 UTC) #5
Dirk Pranke
https://codereview.chromium.org/1256693004/diff/1/net/BUILD.gn File net/BUILD.gn (right): https://codereview.chromium.org/1256693004/diff/1/net/BUILD.gn#newcode1367 net/BUILD.gn:1367: ":balsa", On 2015/07/31 21:32:21, brettw wrote: > I noticed ...
5 years, 4 months ago (2015-07-31 21:42:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256693004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256693004/20001
5 years, 4 months ago (2015-07-31 21:44:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/93685)
5 years, 4 months ago (2015-07-31 21:47:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256693004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256693004/60001
5 years, 4 months ago (2015-07-31 22:07:30 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 4 months ago (2015-07-31 22:33:44 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 22:34:16 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/64df28358d9c22a7ae4e3b2fe229de37c974d180
Cr-Commit-Position: refs/heads/master@{#341428}

Powered by Google App Engine
This is Rietveld 408576698