Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1262393003: [Android WebView] Move browser-side initialization out from Application (Closed)

Created:
5 years, 4 months ago by mnaganov (inactive)
Modified:
5 years, 4 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android WebView] Move browser-side initialization out from Application Application code runs both for the main activity and child services. Browser-side code should be run from Activity.onCreate. BUG=156062 Committed: https://crrev.com/00c4574b9362fc4b7de6346230be5898420f4a5e Cr-Commit-Position: refs/heads/master@{#341208}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -27 lines) Patch
M android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java View 1 4 chunks +25 lines, -0 lines 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java View 3 chunks +4 lines, -27 lines 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/test/AwTestRunnerActivity.java View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mnaganov (inactive)
Please take a look!
5 years, 4 months ago (2015-07-30 21:45:20 UTC) #2
boliu
lgtm https://codereview.chromium.org/1262393003/diff/1/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java File android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java (right): https://codereview.chromium.org/1262393003/diff/1/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java#newcode83 android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java:83: if (!CommandLine.isInitialized()) { This check is repeated in ...
5 years, 4 months ago (2015-07-30 21:53:50 UTC) #3
mnaganov (inactive)
https://codereview.chromium.org/1262393003/diff/1/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java File android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java (right): https://codereview.chromium.org/1262393003/diff/1/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java#newcode83 android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java:83: if (!CommandLine.isInitialized()) { On 2015/07/30 21:53:50, boliu wrote: > ...
5 years, 4 months ago (2015-07-30 21:59:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262393003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262393003/20001
5 years, 4 months ago (2015-07-30 22:01:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-30 22:27:38 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 22:28:15 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/00c4574b9362fc4b7de6346230be5898420f4a5e
Cr-Commit-Position: refs/heads/master@{#341208}

Powered by Google App Engine
This is Rietveld 408576698