NetworkChangeNotifierChromeos: Handle IPConfig property changes on the default network

chromeos/dbus/shill_service_client.h

Index: chromeos/dbus/shill_service_client.h
diff --git a/chromeos/dbus/shill_service_client.h b/chromeos/dbus/shill_service_client.h
index 7f9e9b149419fffbd5ae0dd7c8190edd4d43e43d..05713be8b7f3725aea13dcdaf8dddd9aab8439a4 100644
--- a/chromeos/dbus/shill_service_client.h
+++ b/chromeos/dbus/shill_service_client.h
@@ -49,6 +49,12 @@ class CHROMEOS_EXPORT ShillServiceClient {
                             const std::string& type,
                             const std::string& state,
                             bool add_to_watch_list) = 0;
+    virtual void AddServiceWithIPConfig(const std::string& service_path,

[pneubeck (no reviews), 2013/03/28 10:37:54]

If you want to have initial properties set, then why not add a more scalable
properties argument:
AddServiceWithProperties(...., const DictionaryValue& initial_properties)
(instead of const&, scoped_ptr might be an alternative)

This would also help Manager::ConfigureService and maybe other places.

[gauravsh, 2013/03/28 18:48:54]

I don't anticipate adding more right now. IPConfig was a special case because of
how it's handled in ShillPropertyHandler.

That said, if we end up needing a more general version in the future, we can add
a more general purpose AddServiceWithProperties then.

[stevenjb, 2013/03/28 19:27:13]

I agree that AddServiceWithProperties is probably unnecessary.
SetServiceProperties() would be a more likely addition, since most properties
can reasonably be set after the fact for testing purposes; as mentioned IPConfig
is a special case.

+                                        const std::string& name,
+                                        const std::string& type,
+                                        const std::string& state,
+                                        const std::string& ipconfig_path,
+                                        bool add_to_watch_list) = 0;
     virtual void RemoveService(const std::string& service_path) = 0;
     virtual void SetServiceProperty(const std::string& service_path,
                                     const std::string& property,