NetworkChangeNotifierChromeos: Handle IPConfig property changes on the default network

chromeos/dbus/shill_service_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_DBUS_SHILL_SERVICE_CLIENT_H_
 #define CHROMEOS_DBUS_SHILL_SERVICE_CLIENT_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 31 matching lines @@
 
   // Interface for setting up services for testing. Accessed through
   // GetTestInterface(), only implemented in the stub implementation.
   class TestInterface {
    public:
     virtual void AddService(const std::string& service_path,
                             const std::string& name,
                             const std::string& type,
                             const std::string& state,
                             bool add_to_watch_list) = 0;
+    virtual void AddServiceWithIPConfig(const std::string& service_path,

[pneubeck (no reviews), 2013/03/28 10:37:54]

If you want to have initial properties set, then why not add a more scalable
properties argument:
AddServiceWithProperties(...., const DictionaryValue& initial_properties)
(instead of const&, scoped_ptr might be an alternative)

This would also help Manager::ConfigureService and maybe other places.

[gauravsh, 2013/03/28 18:48:54]

I don't anticipate adding more right now. IPConfig was a special case because of
how it's handled in ShillPropertyHandler.

That said, if we end up needing a more general version in the future, we can add
a more general purpose AddServiceWithProperties then.

[stevenjb, 2013/03/28 19:27:13]

I agree that AddServiceWithProperties is probably unnecessary.
SetServiceProperties() would be a more likely addition, since most properties
can reasonably be set after the fact for testing purposes; as mentioned IPConfig
is a special case.

+                                        const std::string& name,
+                                        const std::string& type,
+                                        const std::string& state,
+                                        const std::string& ipconfig_path,
+                                        bool add_to_watch_list) = 0;
     virtual void RemoveService(const std::string& service_path) = 0;
     virtual void SetServiceProperty(const std::string& service_path,
                                     const std::string& property,
                                     const base::Value& value) = 0;
     virtual const base::DictionaryValue* GetServiceProperties(
         const std::string& service_path) const = 0;
     virtual void ClearServices() = 0;
 
    protected:
     ~TestInterface() {}
@@ skipping 91 matching lines @@
   // Create() should be used instead.
   ShillServiceClient();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ShillServiceClient);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_DBUS_SHILL_SERVICE_CLIENT_H_