chromeos/dbus/shill_ipconfig_client_stub.h - Issue 12634019: NetworkChangeNotifierChromeos: Handle IPConfig property changes on the default network

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/shill_ipconfig_client_stub.h

Issue 12634019: NetworkChangeNotifierChromeos: Handle IPConfig property changes on the default network (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: AddServiceWithIPConfig Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromeos/dbus/shill_ipconfig_client_stub.h

diff --git a/chromeos/dbus/shill_ipconfig_client_stub.h b/chromeos/dbus/shill_ipconfig_client_stub.h

index 1325bba5ef9f7f4e3e307e914af2174f018abc52..c4ab7d1974f9fa510f9510cc2a588bfd9527e15a 100644

--- a/chromeos/dbus/shill_ipconfig_client_stub.h

+++ b/chromeos/dbus/shill_ipconfig_client_stub.h

@@ -42,10 +42,12 @@ class ShillIPConfigClientStub : public ShillIPConfigClient {

const VoidDBusMethodCallback& callback) OVERRIDE;

private:

- // Runs callback with |properties_|.

- void PassProperties(const DictionaryValueCallback& callback) const;

+ // Runs callback with |values|.

+ void PassProperties(const base::DictionaryValue* values,

+ const DictionaryValueCallback& callback) const;

- base::DictionaryValue properties_;

+ // Dictionary of <ipconfig_path, Property dictionaries>

pneubeck (no reviews) 2013/03/28 10:37:54 nit: Property -> property

gauravsh 2013/03/28 18:48:54 Done.

+ base::DictionaryValue stub_ipconfig_;

pneubeck (no reviews) 2013/03/28 10:37:54 plural? this is already part of a stub. 'ipconfigs

gauravsh 2013/03/28 18:48:54 Done.

// Note: This should remain the last member so it'll be destroyed and

// invalidate its weak pointers before any other members are destroyed.

« no previous file with comments | « no previous file | chromeos/dbus/shill_ipconfig_client_stub.cc » ('j') | chromeos/dbus/shill_ipconfig_client_stub.cc » ('J')