NetworkChangeNotifierChromeos: Handle IPConfig property changes on the default network

chromeos/dbus/shill_ipconfig_client_stub.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_DBUS_SHILL_IPCONFIG_CLIENT_STUB_H_
 #define CHROMEOS_DBUS_SHILL_IPCONFIG_CLIENT_STUB_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 24 matching lines @@
                            const std::string& name,
                            const base::Value& value,
                            const VoidDBusMethodCallback& callback) OVERRIDE;
   virtual void ClearProperty(const dbus::ObjectPath& ipconfig_path,
                              const std::string& name,
                              const VoidDBusMethodCallback& callback) OVERRIDE;
   virtual void Remove(const dbus::ObjectPath& ipconfig_path,
                       const VoidDBusMethodCallback& callback) OVERRIDE;
 
  private:
-  // Runs callback with |properties_|.
-  void PassProperties(const DictionaryValueCallback& callback) const;
+  // Runs callback with |values|.
+  void PassProperties(const base::DictionaryValue* values,
+                      const DictionaryValueCallback& callback) const;
 
-  base::DictionaryValue properties_;
+  // Dictionary of <ipconfig_path, Property dictionaries>

[pneubeck (no reviews), 2013/03/28 10:37:54]

nit: Property -> property

[gauravsh, 2013/03/28 18:48:54]

Done.

+  base::DictionaryValue stub_ipconfig_;

[pneubeck (no reviews), 2013/03/28 10:37:54]

plural?
this is already part of a stub. 'ipconfigs_' should be enough.

[gauravsh, 2013/03/28 18:48:54]

Done.

 
   // Note: This should remain the last member so it'll be destroyed and
   // invalidate its weak pointers before any other members are destroyed.
   base::WeakPtrFactory<ShillIPConfigClientStub> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ShillIPConfigClientStub);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_DBUS_SHILL_IPCONFIG_CLIENT_STUB_H_