Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: base/android/jni_string_unittest.cc

Issue 1263333003: [Android] Avoid unnecessary JNI calls for empty string conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Check exceptions... Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/android/jni_string.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/jni_string_unittest.cc
diff --git a/base/android/jni_string_unittest.cc b/base/android/jni_string_unittest.cc
index abd0683170e514d2e705d4f899a72be1df7f5783..3da8b870e6649bfc4140ef2881fe21a30c205471 100644
--- a/base/android/jni_string_unittest.cc
+++ b/base/android/jni_string_unittest.cc
@@ -28,5 +28,21 @@ TEST(JniString, BasicConversionsUTF16) {
EXPECT_EQ(kSimpleString, result);
}
+TEST(JniString, EmptyConversionUTF8) {
+ const std::string kEmptyString = "";
+ JNIEnv* env = AttachCurrentThread();
+ std::string result =
+ ConvertJavaStringToUTF8(ConvertUTF8ToJavaString(env, kEmptyString));
+ EXPECT_EQ(kEmptyString, result);
+}
+
+TEST(JniString, EmptyConversionUTF16) {
+ const string16 kEmptyString = UTF8ToUTF16("");
+ JNIEnv* env = AttachCurrentThread();
+ string16 result =
+ ConvertJavaStringToUTF16(ConvertUTF16ToJavaString(env, kEmptyString));
+ EXPECT_EQ(kEmptyString, result);
+}
+
} // namespace android
} // namespace base
« no previous file with comments | « base/android/jni_string.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698