Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: base/android/jni_string_unittest.cc

Issue 1263333003: [Android] Avoid unnecessary JNI calls for empty string conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Check exceptions... Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/android/jni_string.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/android/jni_string.h" 5 #include "base/android/jni_string.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/scoped_java_ref.h" 8 #include "base/android/scoped_java_ref.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 10 matching lines...) Expand all
21 } 21 }
22 22
23 TEST(JniString, BasicConversionsUTF16) { 23 TEST(JniString, BasicConversionsUTF16) {
24 const string16 kSimpleString = UTF8ToUTF16("SimpleTest16"); 24 const string16 kSimpleString = UTF8ToUTF16("SimpleTest16");
25 JNIEnv* env = AttachCurrentThread(); 25 JNIEnv* env = AttachCurrentThread();
26 string16 result = 26 string16 result =
27 ConvertJavaStringToUTF16(ConvertUTF16ToJavaString(env, kSimpleString)); 27 ConvertJavaStringToUTF16(ConvertUTF16ToJavaString(env, kSimpleString));
28 EXPECT_EQ(kSimpleString, result); 28 EXPECT_EQ(kSimpleString, result);
29 } 29 }
30 30
31 TEST(JniString, EmptyConversionUTF8) {
32 const std::string kEmptyString = "";
33 JNIEnv* env = AttachCurrentThread();
34 std::string result =
35 ConvertJavaStringToUTF8(ConvertUTF8ToJavaString(env, kEmptyString));
36 EXPECT_EQ(kEmptyString, result);
37 }
38
39 TEST(JniString, EmptyConversionUTF16) {
40 const string16 kEmptyString = UTF8ToUTF16("");
41 JNIEnv* env = AttachCurrentThread();
42 string16 result =
43 ConvertJavaStringToUTF16(ConvertUTF16ToJavaString(env, kEmptyString));
44 EXPECT_EQ(kEmptyString, result);
45 }
46
31 } // namespace android 47 } // namespace android
32 } // namespace base 48 } // namespace base
OLDNEW
« no previous file with comments | « base/android/jni_string.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698