Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1263333002: [deoptimizer] Do not pass arguments markers to the debugger. (Closed)

Created:
5 years, 4 months ago by Jarin
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[deoptimizer] Do not pass arguments markers to the debugger. This fixes a bug introduced by r28826 (Unify decoding of deoptimization translations, https://codereview.chromium.org/1136223004), where we started leaking arguments marker sentinel to the debugger, which would then cause crashes. This change replaces the sentinel with the undefined value in the debugger-inspectable frame. BUG=chromium:514362 LOG=n R=yangguo@chromium.org Committed: https://crrev.com/f8dcbf4695f4e729513c447dbc0703c1704c3213 Cr-Commit-Position: refs/heads/master@{#29971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -2 lines) Patch
M src/deoptimizer.cc View 2 chunks +12 lines, -2 lines 0 comments Download
A test/mjsunit/debug-materialized.js View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jarin
Could take a look, please? It turns out the arguments object screw-up was caused by ...
5 years, 4 months ago (2015-08-03 09:55:17 UTC) #1
Yang
On 2015/08/03 09:55:17, Jarin wrote: > Could take a look, please? > > It turns ...
5 years, 4 months ago (2015-08-03 09:56:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263333002/1
5 years, 4 months ago (2015-08-03 09:58:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-03 10:43:29 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 10:43:38 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8dcbf4695f4e729513c447dbc0703c1704c3213
Cr-Commit-Position: refs/heads/master@{#29971}

Powered by Google App Engine
This is Rietveld 408576698