Chromium Code Reviews Chromium Code Reviews
Issue
1136223004:
Unify reading of deoptimization information. (Closed)
DescriptionUnify decoding of deoptimization translations.
This unifies methods Deoptimizer::DoTranslateCommand, Deotpimizer::DoTranslateObject and the arguments object materializer.
To unify these, we have to separate reading of the input frame from writing to the output frame because the argument materializer does not write to output frames.
Instead, we now deoptimize in following stages:
1. Read out the input frame/registers, decode them using the translations from the deoptimizer and store them in the deoptimizer (Deoptimizer::translated_state_). This is done in TranslatedState::Init.
2. Write out into the output frame buffer all the values that do not require allocation. We also remember references to the values that require materialization. As before, this is done in Deoptimizer::DoCompute*Frame method, but instead calling to DoTranslateCommand, we use the translated frame to obtain the values and write them to the output frames.
3. The platform specific code then sets up the output frames and calls into the deoptimization notification. This has not been changed at all.
4. Once the stack is setup, we handlify all the references in the saved translated values (TranslatedState::Prepare).
5. Finally, we materialize all the values we remembered in step (1) and write them to their frames on the stack (using the TranslatedValue::GetValue method).
BUG=
Committed: https://crrev.com/9127d4eef4248c6a5266c6ed9e9a32a4ce2423eb
Cr-Commit-Position: refs/heads/master@{#28826}
Patch Set 1 #Patch Set 2 : Replace SlotRefValueBuilder #Patch Set 3 : Fix to make Win happier #Patch Set 4 : Tweaks #Patch Set 5 : Rebase #Patch Set 6 : Eager Smi materialization for doubles, size_t fix #Patch Set 7 : Using new deoptimizer everywhere now #Patch Set 8 : Remove the old translation logic #Patch Set 9 : Rebase #
Total comments: 14
Patch Set 10 : Address review comments #Patch Set 11 : Fix too restrictive check #
Messages
Total messages: 11 (2 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
