Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 12633004: Remove apparently spurious DCHECK (Closed)

Created:
7 years, 9 months ago by abarth-chromium
Modified:
7 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Remove apparently spurious DCHECK This DCHECK will be triggered when http://trac.webkit.org/changeset/145097 is re-landed.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M webkit/glue/resource_request_body.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
Sorry for the broad list of reviewers, but I wasn't sure who the best person ...
7 years, 9 months ago (2013-03-07 20:31:37 UTC) #1
jamesr
LGTM for OWNERS, but you probably want a subject matter expert to review for concept.
7 years, 9 months ago (2013-03-07 20:53:36 UTC) #2
michaeln
lgtm The check is actually not sprurious, it indicates something is amiss with the FormData ...
7 years, 9 months ago (2013-03-07 21:55:41 UTC) #3
abarth-chromium
7 years, 9 months ago (2013-03-07 23:03:46 UTC) #4
Message was sent while issue was closed.
I didn't land this patch.

Powered by Google App Engine
This is Rietveld 408576698