Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 1263213004: Change renderer compositor command buffer to be 64kB (Closed)

Created:
5 years, 4 months ago by jbauman
Modified:
5 years, 4 months ago
Reviewers:
no sievers
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change renderer compositor command buffer to be 64kB With delegated rendering and either software rasterization or GPU rasterization in a worker context, the compositor context will execute very few commands. Therefore, we can reduce the size of the command buffer from 1MB to 64kB with no effect on performance. Committed: https://crrev.com/5e420d38f61d4c476a8916a2ff981a5e0330e68b Cr-Commit-Position: refs/heads/master@{#341874}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M content/renderer/render_widget.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jbauman
This should help reduce memory usage on android. We can probably also do this with ...
5 years, 4 months ago (2015-08-03 21:23:45 UTC) #2
no sievers
That's a good idea, but is 16kb maybe a bit aggressive? In compositor_impl_android.cc we set ...
5 years, 4 months ago (2015-08-03 21:42:09 UTC) #3
jbauman
On 2015/08/03 21:42:09, sievers wrote: > That's a good idea, but is 16kb maybe a ...
5 years, 4 months ago (2015-08-04 01:46:47 UTC) #4
no sievers
lgtm
5 years, 4 months ago (2015-08-04 17:49:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263213004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263213004/20001
5 years, 4 months ago (2015-08-05 08:16:17 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-05 09:33:13 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 09:34:00 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5e420d38f61d4c476a8916a2ff981a5e0330e68b
Cr-Commit-Position: refs/heads/master@{#341874}

Powered by Google App Engine
This is Rietveld 408576698