Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: components/security_interstitials/metrics_helper.cc

Issue 1263133002: Fix SSL bad clock interstitial crash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: And for good measure, history_service_ too Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/security_interstitials/metrics_helper.cc
diff --git a/components/security_interstitials/metrics_helper.cc b/components/security_interstitials/metrics_helper.cc
index ae2444de86019a1996d5f817062c210ec847d87d..d300b65786ca08a51b9e07a5ac45d14d8ab3d5c6 100644
--- a/components/security_interstitials/metrics_helper.cc
+++ b/components/security_interstitials/metrics_helper.cc
@@ -31,10 +31,10 @@ MetricsHelper::MetricsHelper(const GURL& request_url,
num_visits_(-1) {
DCHECK(!settings_.metric_prefix.empty());
if (settings_.rappor_report_type == rappor::NUM_RAPPOR_TYPES) // Default.
- rappor_service = nullptr;
- DCHECK(!rappor_service || !settings_.rappor_prefix.empty());
- if (history_service) {
- history_service->GetVisibleVisitCountToHost(
+ rappor_service_ = nullptr;
+ DCHECK(!rappor_service_ || !settings_.rappor_prefix.empty());
+ if (history_service_) {
estark 2015/07/31 00:53:34 Wait, is this right? It looks like this should act
felt 2015/07/31 00:56:56 Done.
+ history_service_->GetVisibleVisitCountToHost(
request_url_,
base::Bind(&MetricsHelper::OnGotHistoryCount, base::Unretained(this)),
&request_tracker_);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698