Fix SSL bad clock interstitial crash

components/security_interstitials/metrics_helper.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/security_interstitials/metrics_helper.h"
 
 #include "base/metrics/histogram.h"
 #include "components/history/core/browser/history_service.h"
 #include "components/rappor/rappor_service.h"
 #include "components/rappor/rappor_utils.h"
@@ skipping 13 matching lines @@
 MetricsHelper::MetricsHelper(const GURL& request_url,
                              const ReportDetails settings,
                              history::HistoryService* history_service,
                              rappor::RapporService* rappor_service)
     : request_url_(request_url),
       settings_(settings),
       rappor_service_(rappor_service),
       num_visits_(-1) {
   DCHECK(!settings_.metric_prefix.empty());
   if (settings_.rappor_report_type == rappor::NUM_RAPPOR_TYPES)  // Default.
-    rappor_service = nullptr;
-  DCHECK(!rappor_service || !settings_.rappor_prefix.empty());
-  if (history_service) {
-    history_service->GetVisibleVisitCountToHost(
+    rappor_service_ = nullptr;
+  DCHECK(!rappor_service_ || !settings_.rappor_prefix.empty());
+  if (history_service_) {

[estark, 2015/07/31 00:53:34]

Wait, is this right? It looks like this should actually be |history_service|.

[felt, 2015/07/31 00:56:56]

Done.

+    history_service_->GetVisibleVisitCountToHost(
         request_url_,
         base::Bind(&MetricsHelper::OnGotHistoryCount, base::Unretained(this)),
         &request_tracker_);
   }
 }
 
 // Directly adds to the UMA histograms, using the same properties as
 // UMA_HISTOGRAM_ENUMERATION, because the macro doesn't allow non-constant
 // histogram names. Reports to Rappor for certain decisions.
 void MetricsHelper::RecordUserDecision(Decision decision) {
@@ skipping 59 matching lines @@
 }
 
 void MetricsHelper::OnGotHistoryCount(bool success,
                                       int num_visits,
                                       base::Time /*first_visit*/) {
   if (success)
     num_visits_ = num_visits;
 }
 
 }  // namespace security_interstitials