Fix SSL bad clock interstitial crash

Fix SSL bad clock interstitial crash

security_interstitials::MetricsHelper shouldn't try to send Rappor
reports if the Rappor report type hasn't been set, even if the caller
specified a RapporService. A crash was happening because the
MetricsHelper *was* trying to send reports with an invalid report type.

The root cause of the bug is that the constructor was setting
|rappor_service| instead of |rappor_service_|.

BUG=515564
R=estark@chromium.org

Committed: https://crrev.com/159abd0551976b9a6c5095314c0b7696b383f753
Cr-Commit-Position: refs/heads/master@{#341264}

[felt, 2015-07-31 00:24:40]

Patchset #1 (id:1) has been deleted

[felt, 2015-07-31 00:26:55]

estark, PTAL?

P.S. please be nice and muffle your laughter

[estark, 2015-07-31 00:53:34]

I successfully did not laugh until I heard you curse and saw the "Same mistake
on the next line" patch set.

https://codereview.chromium.org/1263133002/diff/60001/components/security_int...
File components/security_interstitials/metrics_helper.cc (right):

https://codereview.chromium.org/1263133002/diff/60001/components/security_int...
components/security_interstitials/metrics_helper.cc:36: if (history_service_) {
Wait, is this right? It looks like this should actually be |history_service|.

[felt, 2015-07-31 00:56:56]

https://codereview.chromium.org/1263133002/diff/60001/components/security_int...
File components/security_interstitials/metrics_helper.cc (right):

https://codereview.chromium.org/1263133002/diff/60001/components/security_int...
components/security_interstitials/metrics_helper.cc:36: if (history_service_) {
On 2015/07/31 00:53:34, estark wrote:
> Wait, is this right? It looks like this should actually be |history_service|.

Done.

[estark, 2015-07-31 00:59:46]

LGTM

[felt, 2015-07-31 01:32:54]

The CQ bit was checked by felt@chromium.org

[commit-bot: I haz the power, 2015-07-31 01:33:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1263133002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1263133002/80001

[commit-bot: I haz the power, 2015-07-31 01:38:30]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-07-31 01:39:07]

Patchset 4 (id:??) landed as
https://crrev.com/159abd0551976b9a6c5095314c0b7696b383f753
Cr-Commit-Position: refs/heads/master@{#341264}