Issue 126313002: Gracefully handle <meta http-equiv name content> elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126313002: Gracefully handle <meta http-equiv name content> elements. (Closed)

Created:
6 years, 11 months ago by sof

Modified:
6 years, 11 months ago

Reviewers:
esprehn, kenneth.r.christiansen, eseidel

CC:
blink-reviews, kenneth.christiansen, dglazkov+blink, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Gracefully handle <meta http-equiv name content> elements. If presented with a <meta> element having both a 'name' and 'http-equiv' attribute, try interpreting the 'name' attribute first before _also_ considering 'http-equiv'. The specification requires that at most one of these attributes to be used, but authors don't always keep their side of the bargain. This simply reinstates previous behavior, something that regressed in https://codereview.chromium.org/25728006/ (it ignores 'http-equiv' if 'name' is supplied, even if the latter is set to some unknown value.) R= BUG=332090 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164642

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -15 lines)			Patch
A	LayoutTests/http/tests/misc/meta-http-equiv-and-name.html	View	1 chunk	+18 lines, -0 lines	0 comments	Download
A +	LayoutTests/http/tests/misc/meta-http-equiv-and-name-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/html/HTMLMetaElement-in.cpp	View	1 chunk	+15 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/126313002/1

6 years, 11 months ago (2014-01-07 22:11:03 UTC) #3

Message was sent while issue was closed.

Change committed as 164642

Expand Messages | Collapse Messages