Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 1263113002: DM: track a direct/indirect bit for each Sink too. (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM: track a direct/indirect bit for each Sink too. The decoding tests can now veto indirect sinks like pipe-8888. This moves Sink type detection from automatic to explicit; I can't think of any way to automatically differentiate pipe-8888 from 8888 based only on the output. (They should ideally be identical, after all.) BUG=skia:4138 Committed: https://skia.googlesource.com/skia/+/99cab4e3081e7e0ae8a72eb53cb42b1bef3719a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -18 lines) Patch
M dm/DM.cpp View 3 chunks +1 line, -8 lines 0 comments Download
M dm/DMSrcSink.h View 13 chunks +21 lines, -4 lines 0 comments Download
M dm/DMSrcSink.cpp View 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein_C
5 years, 4 months ago (2015-07-30 20:05:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263113002/1
5 years, 4 months ago (2015-07-30 20:05:32 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-30 20:13:33 UTC) #6
scroggo
lgtm
5 years, 4 months ago (2015-07-31 13:42:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263113002/1
5 years, 4 months ago (2015-07-31 13:42:38 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 13:43:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/99cab4e3081e7e0ae8a72eb53cb42b1bef3719a3

Powered by Google App Engine
This is Rietveld 408576698